third_party/WebKit/LayoutTests/media/video-replaces-poster.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-replaces-poster.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-preload-none-no-stalled-event.html ('k') | third_party/WebKit/LayoutTests/media/video-scales-in-media-document.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="media-file.js"></script>	4 <script src="media-file.js"></script>

	5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	6 (Please avoid writing new tests using video-test.js) -->

5 <script src="video-test.js"></script>	7 <script src="video-test.js"></script>

6 <script type="text/javascript" charset="utf-8">	8 <script type="text/javascript" charset="utf-8">

7 function doSetup()	9 function doSetup()

8 {	10 {

9 findMediaElement();	11 findMediaElement();

10 video.src = findMediaFile('video', 'content/test');	12 video.src = findMediaFile('video', 'content/test');

11 video.addEventListener("canplaythrough", function () {	13 video.addEventListener("canplaythrough", function () {

12 video.currentTime = 1; // so the snapshot always has the same f rame.	14 video.currentTime = 1; // so the snapshot always has the same f rame.

13 });	15 });

14 video.addEventListener("seeked", function() {	16 video.addEventListener("seeked", function() {

15 testExpected(video.currentTime, 1);	17 testExpected(video.currentTime, 1);

16 if (window.testRunner)	18 if (window.testRunner)

17 testRunner.notifyDone();	19 testRunner.notifyDone();

18 });	20 });

19 }	21 }

20 window.addEventListener('load', doSetup, false);	22 window.addEventListener('load', doSetup, false);

21 </script>	23 </script>

22 </head>	24 </head>

23 <body>	25 <body>

24 <p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=34966">https:// bugs.webkit.org/show_bug.cgi?id=34966</a>. <br>	26 <p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=34966">https:// bugs.webkit.org/show_bug.cgi?id=34966</a>. <br>

25 You should see the video below.</p>	27 You should see the video below.</p>

26	28

27 <video width="480" height="270" poster="content/abe.png"></video>	29 <video width="480" height="270" poster="content/abe.png"></video>

28 </body>	30 </body>

29 </html>	31 </html>

OLD	NEW