third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-no-autoplay.html ('k') | third_party/WebKit/LayoutTests/media/video-pause-empty-events.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <p>Test that no timeupdate event fires during loading.</p>	4 <p>Test that no timeupdate event fires during loading.</p>

5 <video></video>	5 <video></video>

6 <script src="media-file.js"></script>	6 <script src="media-file.js"></script>

	7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	8 (Please avoid writing new tests using video-test.js) -->

7 <script src="video-test.js"></script>	9 <script src="video-test.js"></script>

8 <script>	10 <script>

9 waitForEvent("loadstart");	11 waitForEvent("loadstart");

10 waitForEvent("loadedmetadata");	12 waitForEvent("loadedmetadata");

11 waitForEvent("loadeddata");	13 waitForEvent("loadeddata");

12 waitForEvent("canplay");	14 waitForEvent("canplay");

13 waitForEvent("canplaythrough", function()	15 waitForEvent("canplaythrough", function()

14 {	16 {

15 // Let pending async events fire before ending the test.	17 // Let pending async events fire before ending the test.

16 window.setTimeout(function() { endTest(); }, 0);	18 window.setTimeout(function() { endTest(); }, 0);

17 });	19 });

18 waitForEventAndFail("timeupdate");	20 waitForEventAndFail("timeupdate");

19	21

20 video.src = findMediaFile("video", "content/test");	22 video.src = findMediaFile("video", "content/test");

21 </script>	23 </script>

22 </body>	24 </body>

23 </html>	25 </html>

OLD	NEW