third_party/WebKit/LayoutTests/media/video-display-aspect-ratio.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-display-aspect-ratio.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-delay-load-event.html ('k') | third_party/WebKit/LayoutTests/media/video-display-none-crash.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <video controls></video>	1 <video controls></video>

2 <script src=media-file.js></script>	2 <script src=media-file.js></script>

	3 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	4 (Please avoid writing new tests using video-test.js) -->

3 <script src=video-test.js></script>	5 <script src=video-test.js></script>

4 <script>	6 <script>

5 testExpected("video.videoWidth", 0, "==");	7 testExpected("video.videoWidth", 0, "==");

6 testExpected("video.videoHeight", 0, "==");	8 testExpected("video.videoHeight", 0, "==");

7	9

8 waitForEvent('loadedmetadata', function () {	10 waitForEvent('loadedmetadata', function () {

9 testExpected("video.videoWidth", 427, "==");	11 testExpected("video.videoWidth", 427, "==");

10 testExpected("video.videoHeight", 240, "==");	12 testExpected("video.videoHeight", 240, "==");

11 endTest();	13 endTest();

12 } );	14 } );

13	15

14 video.src = findMediaFile("video", "content/test-par-16-9");	16 video.src = findMediaFile("video", "content/test-par-16-9");

15 </script>	17 </script>

OLD	NEW