Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-hidden-audio.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <video controls></video> 1 <video controls></video>
2 <p>Test that hiding volume / mute buttons works as expected.</p> 2 <p>Test that hiding volume / mute buttons works as expected.</p>
3 <script src=media-file.js></script> 3 <script src=media-file.js></script>
4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
5 (Please avoid writing new tests using video-test.js) -->
4 <script src=video-test.js></script> 6 <script src=video-test.js></script>
5 <script src=media-controls.js></script> 7 <script src=media-controls.js></script>
6 <script> 8 <script>
7 video.src = findMediaFile("video", "content/test"); 9 video.src = findMediaFile("video", "content/test");
8 run("video.load()"); 10 run("video.load()");
9 waitForEvent("canplaythrough", function () { 11 waitForEvent("canplaythrough", function () {
10 // Enable hidden audio preferences to take effect. 12 // Enable hidden audio preferences to take effect.
11 run("window.internals.setAllowHiddenVolumeControls(video, true)"); 13 run("window.internals.setAllowHiddenVolumeControls(video, true)");
12 // Request non-hidden audio controls. 14 // Request non-hidden audio controls.
13 run("window.internals.settings.setPreferHiddenVolumeControls(false)"); 15 run("window.internals.settings.setPreferHiddenVolumeControls(false)");
(...skipping 21 matching lines...) Expand all
35 // For muted video, the volume slider will hide but the mute 37 // For muted video, the volume slider will hide but the mute
36 // button should stay, since we always have it present for media 38 // button should stay, since we always have it present for media
37 // which have audio. 39 // which have audio.
38 run("video.muted = true"); 40 run("video.muted = true");
39 testExpected("getComputedStyle(muteButton).display", "none", '!='); 41 testExpected("getComputedStyle(muteButton).display", "none", '!=');
40 testExpected("getComputedStyle(volumeSlider).display", "none", '=='); 42 testExpected("getComputedStyle(volumeSlider).display", "none", '==');
41 43
42 endTest(); 44 endTest();
43 }); 45 });
44 </script> 46 </script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698