third_party/WebKit/LayoutTests/media/video-controls-captions.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-captions.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-captions-load-by-lang.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5 <title>Test closed caption button toggling.</title>	5 <title>Test closed caption button toggling.</title>

6 <script src=media-file.js></script>	6 <script src=media-file.js></script>

7 <script src=media-controls.js></script>	7 <script src=media-controls.js></script>

	8 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	9 (Please avoid writing new tests using video-test.js) -->

8 <script src=video-test.js></script>	10 <script src=video-test.js></script>

9 <script>	11 <script>

10 var track;	12 var track;

11	13

12 function addTextTrackThroughJS()	14 function addTextTrackThroughJS()

13 {	15 {

14 consoleWrite("");	16 consoleWrite("");

15 consoleWrite(" Add a text track through JS to the video element ");	17 consoleWrite(" Add a text track through JS to the video element ");

16 var t = video.addTextTrack('captions', 'English', 'en');	18 var t = video.addTextTrack('captions', 'English', 'en');

17 t.addCue(new VTTCue(0.0, 10.0, 'Some random caption text'));	19 t.addCue(new VTTCue(0.0, 10.0, 'Some random caption text'));

(...skipping 97 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
115 }	117 }

116 </script>	118 </script>

117 </head>	119 </head>

118 <body onload="loaded()">	120 <body onload="loaded()">

119 <p>Tests that the closed captions button, when toggled, updates the text tra ck display area.</p>	121 <p>Tests that the closed captions button, when toggled, updates the text tra ck display area.</p>

120 <video controls>	122 <video controls>

121 <track src="track/captions-webvtt/captions-fast.vtt" kind="captions" onl oad="testCCButtonToggling()">	123 <track src="track/captions-webvtt/captions-fast.vtt" kind="captions" onl oad="testCCButtonToggling()">

122 </video>	124 </video>

123 </body>	125 </body>

124 </html>	126 </html>

OLD	NEW