Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-word-breaking.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script> 3 <script>
4 if (window.internals.settings) 4 if (window.internals.settings)
5 { 5 {
6 // This should not be necessary, but due to crbug.com/372245 style 6 // This should not be necessary, but due to crbug.com/372245 style
7 // gets dirtied during layout in LayoutTextTrackContainer which 7 // gets dirtied during layout in LayoutTextTrackContainer which
8 // causes assertions to fail when Document::scrollingElement is 8 // causes assertions to fail when Document::scrollingElement is
9 // queried during compositing update (a valid request). 9 // queried during compositing update (a valid request).
10 window.internals.settings.setCompositorWorkerEnabled(false); 10 window.internals.settings.setCompositorWorkerEnabled(false);
11 } 11 }
12 </script> 12 </script>
13 <script src=../media-file.js></script> 13 <script src=../media-file.js></script>
14 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
15 (Please avoid writing new tests using video-test.js) -->
14 <script src=../video-test.js></script> 16 <script src=../video-test.js></script>
15 <script src=../media-controls.js></script> 17 <script src=../media-controls.js></script>
16 <script> 18 <script>
17 19
18 var singleLineRect; 20 var singleLineRect;
19 21
20 function testUnbreakableLine() 22 function testUnbreakableLine()
21 { 23 {
22 var multiLineRect = textTrackDisplayElement(video).firstChild.firstC hild.getBoundingClientRect(); 24 var multiLineRect = textTrackDisplayElement(video).firstChild.firstC hild.getBoundingClientRect();
23 var ratio = multiLineRect.height / singleLineRect.height; 25 var ratio = multiLineRect.height / singleLineRect.height;
(...skipping 18 matching lines...) Expand all
42 } 44 }
43 45
44 </script> 46 </script>
45 </head> 47 </head>
46 <body onload="loaded()"> 48 <body onload="loaded()">
47 <video controls > 49 <video controls >
48 <track src="captions-webvtt/long-word.vtt" kind="captions" default> 50 <track src="captions-webvtt/long-word.vtt" kind="captions" default>
49 </video> 51 </video>
50 </body> 52 </body>
51 </html> 53 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698