third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-webvtt-tc026-voice.html ('k') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc028-unsupported-markup.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5	5

6 <script src=../media-file.js></script>	6 <script src=../media-file.js></script>

	7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	8 (Please avoid writing new tests using video-test.js) -->

7 <script src=../video-test.js></script>	9 <script src=../video-test.js></script>

8 <script>	10 <script>

9	11

10 function trackLoaded()	12 function trackLoaded()

11 {	13 {

12 findMediaElement();	14 findMediaElement();

13 testExpected("video.textTracks[0].cues.length", "0");	15 testExpected("video.textTracks[0].cues.length", "0");

14	16

15 endTest();	17 endTest();

16 }	18 }

17	19

18 </script>	20 </script>

19 </head>	21 </head>

20 <body>	22 <body>

21 <p>Tests that empty cues are discarded.</p>	23 <p>Tests that empty cues are discarded.</p>

22 <video>	24 <video>

23 <track src="captions-webvtt/tc027-empty-cue.vtt" onload="trackLoaded ()" default>	25 <track src="captions-webvtt/tc027-empty-cue.vtt" onload="trackLoaded ()" default>

24 </video>	26 </video>

25 </body>	27 </body>

26 </html>	28 </html>

OLD	NEW