third_party/WebKit/LayoutTests/media/track/track-webvtt-tc005-header-comment.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc005-header-comment.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-webvtt-tc004-magic-header.html ('k') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc006-cue-identifiers.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5	5

6 <script src=../media-file.js></script>	6 <script src=../media-file.js></script>

	7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	8 (Please avoid writing new tests using video-test.js) -->

7 <script src=../video-test.js></script>	9 <script src=../video-test.js></script>

8 <script>	10 <script>

9	11

10 numberOfTrackTests = 2;	12 numberOfTrackTests = 2;

11	13

12 function trackLoaded()	14 function trackLoaded()

13 {	15 {

14 numberOfTracksLoaded++;	16 numberOfTracksLoaded++;

15 if (numberOfTracksLoaded == numberOfTrackTests) {	17 if (numberOfTracksLoaded == numberOfTrackTests) {

16 testTrack(0);	18 testTrack(0);

17 testTrack(1);	19 testTrack(1);

18 }	20 }

19 }	21 }

20	22

21 function testTrack(i)	23 function testTrack(i)

22 {	24 {

23 var expected =	25 var expected =

24 {	26 {

25 length : 2,	27 length : 2,

26 tests:	28 tests:

27 [	29 [

28 {	30 {

29 property : "id",	31 property : "id",

30 values : [1, 2],	32 values : [1, 2],

31 },	33 },

32 {	34 {

33 property : "startTime",	35 property : "startTime",

(...skipping 15 matching lines...) Expand all Loading...
49 }	51 }

50 </script>	52 </script>

51 </head>	53 </head>

52 <body onload="enableAllTextTracks()">	54 <body onload="enableAllTextTracks()">

53 <p>Tests that the optional comment area under the "WEBVTT" file header i s properly ignored. Also, default settings and styling are currently ignored (t reated as faulty cues).</p>	55 <p>Tests that the optional comment area under the "WEBVTT" file header i s properly ignored. Also, default settings and styling are currently ignored (t reated as faulty cues).</p>

54 <video>	56 <video>

55 <track src="captions-webvtt/tc005-default-styles.vtt" onload="trackL oaded()">	57 <track src="captions-webvtt/tc005-default-styles.vtt" onload="trackL oaded()">

56 <track src="captions-webvtt/tc005-metadata-area.vtt" onload="trackLo aded()">	58 <track src="captions-webvtt/tc005-metadata-area.vtt" onload="trackLo aded()">

57 </video>	59 </video>

58 </body>	60 </body>

59 </html>	61 </html>

OLD	NEW