third_party/WebKit/LayoutTests/media/track/track-remove-by-setting-innerHTML.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-remove-by-setting-innerHTML.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-remove-active-cue-crash.html ('k') | third_party/WebKit/LayoutTests/media/track/track-remove-insert-ready-state.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../media-file.js"></script>	4 <script src="../media-file.js"></script>

	5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	6 (Please avoid writing new tests using video-test.js) -->

5 <script src="../video-test.js"></script>	7 <script src="../video-test.js"></script>

6 <script type="text/javascript">	8 <script type="text/javascript">

7 var firstSeek = true;	9 var firstSeek = true;

8	10

9 function seeked()	11 function seeked()

10 {	12 {

11 if (!firstSeek) {	13 if (!firstSeek) {

12 endTest();	14 endTest();

13 return;	15 return;

14 }	16 }

(...skipping 22 matching lines...) Expand all Loading...
37 <body onload=loaded()>	39 <body onload=loaded()>

38 <video>	40 <video>

39 <track default="" src="captions-webvtt/captions-gaps.vtt">	41 <track default="" src="captions-webvtt/captions-gaps.vtt">

40 </video>	42 </video>

41 <div>	43 <div>

42 This test makes sure that removing a track by setting video.innerHTML doesn't crash (https://bugs.webkit.org/show_bug.cgi?id=100981).	44 This test makes sure that removing a track by setting video.innerHTML doesn't crash (https://bugs.webkit.org/show_bug.cgi?id=100981).

43 <p>If this test does not crash, it passes.</p>	45 <p>If this test does not crash, it passes.</p>

44 </div>	46 </div>

45 </body>	47 </body>

46 </html>	48 </html>

OLD	NEW