third_party/WebKit/LayoutTests/media/track/track-removal-crash.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-removal-crash.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-mode-triggers-loading.html ('k') | third_party/WebKit/LayoutTests/media/track/track-remove-active-cue-crash.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src=../media-file.js></script>	4 <script src=../media-file.js></script>

5 <script src=../media-controls.js></script>	5 <script src=../media-controls.js></script>

	6 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	7 (Please avoid writing new tests using video-test.js) -->

6 <script src=../video-test.js></script>	8 <script src=../video-test.js></script>

7	9

8 <script>	10 <script>

9 function startTest()	11 function startTest()

10 {	12 {

11 document.getElementsByTagName('track')[0].track.mode = 'showing';	13 document.getElementsByTagName('track')[0].track.mode = 'showing';

12 document.getElementsByTagName('track')[1].track.mode = 'showing';	14 document.getElementsByTagName('track')[1].track.mode = 'showing';

13	15

14 setTimeout("CFcrash()", 10);	16 setTimeout("CFcrash()", 10);

15 }	17 }

(...skipping 29 matching lines...) Expand all Loading...
45 <video autoplay>	47 <video autoplay>

46 <!-- Can't use findMediaElement() as test doesn't crash, so source needs to be specified here -->	48 <!-- Can't use findMediaElement() as test doesn't crash, so source needs to be specified here -->

47 <source src="../content/test.ogv">	49 <source src="../content/test.ogv">

48 <source src="../content/test.mp4">	50 <source src="../content/test.mp4">

49 <track src="captions-webvtt/captions-fast.vtt">	51 <track src="captions-webvtt/captions-fast.vtt">

50 <track src="captions-webvtt/captions-fast.vtt">	52 <track src="captions-webvtt/captions-fast.vtt">

51 </video>	53 </video>

52 </label>	54 </label>

53 </body>	55 </body>

54 </html>	56 </html>

OLD	NEW