third_party/WebKit/LayoutTests/media/track/track-insert-after-load-crash.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-insert-after-load-crash.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../media-file.js"></script>	4 <script src="../media-file.js"></script>

	5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	6 (Please avoid writing new tests using video-test.js) -->

5 <script src="../video-test.js"></script>	7 <script src="../video-test.js"></script>

6 </head>	8 </head>

7 <body>	9 <body>

8 <p>Tests that inserting a <track> element immediately after a load() doesn't crash.</p>	10 <p>Tests that inserting a <track> element immediately after a load() doesn't crash.</p>

9 <video id="v"></video>	11 <video id="v"></video>

10 <script>	12 <script>

11 var v = document.querySelector('#v');	13 var v = document.querySelector('#v');

12 v.src = findMediaFile('video', '../content/test');	14 v.src = findMediaFile('video', '../content/test');

13 v.load();	15 v.load();

14 v.appendChild(document.createElement('track'));	16 v.appendChild(document.createElement('track'));

15 v.addEventListener('loadedmetadata', endTest);	17 v.addEventListener('loadedmetadata', endTest);

16 </script>	18 </script>

17 </body>	19 </body>

18 </html>	20 </html>

OLD	NEW