third_party/WebKit/LayoutTests/media/track/track-disabled-addcue.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-disabled-addcue.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-disabled.html ('k') | third_party/WebKit/LayoutTests/media/track/track-element-dom-change-crash.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../media-file.js"></script>	4 <script src="../media-file.js"></script>

	5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	6 (Please avoid writing new tests using video-test.js) -->

5 <script src="../video-test.js"></script>	7 <script src="../video-test.js"></script>

6 <script>	8 <script>

7 function onLoad()	9 function onLoad()

8 {	10 {

9 if (window.testRunner)	11 if (window.testRunner)

10 testRunner.dumpAsText();	12 testRunner.dumpAsText();

11	13

12 var cueDuration = 0.1;	14 var cueDuration = 0.1;

13 var video = document.querySelector("#vid");	15 var video = document.querySelector("#vid");

14 var track = video.addTextTrack("subtitles");	16 var track = video.addTextTrack("subtitles");

(...skipping 20 matching lines...) Expand all Loading...
35 });	37 });

36 video.play();	38 video.play();

37 }	39 }

38 </script>	40 </script>

39 </head>	41 </head>

40 <body onload="onLoad()">	42 <body onload="onLoad()">

41 <p>Test adding cues to a disabled text track. </p>	43 <p>Test adding cues to a disabled text track. </p>

42 <video id="vid" src="../content/test.ogv" controls></video>	44 <video id="vid" src="../content/test.ogv" controls></video>

43 </body>	45 </body>

44 </html>	46 </html>

OLD	NEW