third_party/WebKit/LayoutTests/media/track/track-cue-inline-assertion-crash.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-inline-assertion-crash.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-mutable.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5	5

6 <script src=../media-file.js></script>	6 <script src=../media-file.js></script>

	7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	8 (Please avoid writing new tests using video-test.js) -->

7 <script src=../video-test.js></script>	9 <script src=../video-test.js></script>

8	10

9 <script>	11 <script>

10 function startTest()	12 function startTest()

11 {	13 {

12 findMediaElement();	14 findMediaElement();

13	15

14 consoleWrite(" Add a text track through JS to the video element ");	16 consoleWrite(" Add a text track through JS to the video element ");

15 var t = video.addTextTrack('captions', 'English', 'en');	17 var t = video.addTextTrack('captions', 'English', 'en');

16	18

(...skipping 14 matching lines...) Expand all Loading...
31	33

32 <body onload="startTest()">	34 <body onload="startTest()">

33 <p>Tests that adding a track and changing its mode through JS doesn't cr ash the browser.</p>	35 <p>Tests that adding a track and changing its mode through JS doesn't cr ash the browser.</p>

34 <video controls>	36 <video controls>

35 <!-- If the src is specified through JS after the body load, the tes t doesn't crash anymore. -->	37 <!-- If the src is specified through JS after the body load, the tes t doesn't crash anymore. -->

36 <source src="../content/test.mp4" type="video/mp4">	38 <source src="../content/test.mp4" type="video/mp4">

37 <source src="../content/test.ogv" type="video/ogg">	39 <source src="../content/test.ogv" type="video/ogg">

38 </video>	40 </video>

39 </body>	41 </body>

40 </html>	42 </html>

OLD	NEW