third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src=../media-file.js></script>	4 <script src=../media-file.js></script>

	5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	6 (Please avoid writing new tests using video-test.js) -->

5 <script src=../video-test.js></script>	7 <script src=../video-test.js></script>

6 <script>	8 <script>

7 var fragment;	9 var fragment;

8 function startTest()	10 function startTest()

9 {	11 {

10 var emptyCue = new VTTCue(0, 0, "");	12 var emptyCue = new VTTCue(0, 0, "");

11 fragment = emptyCue.getCueAsHTML();	13 fragment = emptyCue.getCueAsHTML();

12	14

13 consoleWrite(" The getCueAsHTML() method should return a document fragment ");	15 consoleWrite(" The getCueAsHTML() method should return a document fragment ");

14 testExpected("fragment", null, "!=");	16 testExpected("fragment", null, "!=");

(...skipping 10 matching lines...) Expand all Loading...
25 endTest();	27 endTest();

26 }	28 }

27 </script>	29 </script>

28 </head>	30 </head>

29	31

30 <body onload="startTest()">	32 <body onload="startTest()">

31 <p>Tests that having an empty cue does not crash when calling getCueAsHT ML().</p>	33 <p>Tests that having an empty cue does not crash when calling getCueAsHT ML().</p>

32 <video controls />	34 <video controls />

33 </body>	35 </body>

34 </html>	36 </html>

OLD	NEW