third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-author-settings.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src=../media-file.js></script>	2 <script src=../media-file.js></script>

	3 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	4 (Please avoid writing new tests using video-test.js) -->

3 <script src=../video-test.js></script>	5 <script src=../video-test.js></script>

4 <script src=../media-controls.js></script>	6 <script src=../media-controls.js></script>

5 <script>	7 <script>

6	8

7 function applyUserOverrideSettings() {	9 function applyUserOverrideSettings() {

8 if (window.internals) {	10 if (window.internals) {

9 internals.settings.setTextTrackTextColor("purple");	11 internals.settings.setTextTrackTextColor("purple");

10 internals.settings.setTextTrackTextSize("14px");	12 internals.settings.setTextTrackTextSize("14px");

11 }	13 }

12 }	14 }

(...skipping 28 matching lines...) Expand all Loading...
41 findMediaElement();	43 findMediaElement();

42 video.src = findMediaFile('video', '../content/test');	44 video.src = findMediaFile('video', '../content/test');

43 video.currentTime = 0.1;	45 video.currentTime = 0.1;

44 waitForEvent('canplaythrough', verifyDefaultSettings);	46 waitForEvent('canplaythrough', verifyDefaultSettings);

45 }	47 }

46	48

47 </script>	49 </script>

48 <video>	50 <video>

49 <track src="captions-webvtt/styling.vtt" kind="captions" default>	51 <track src="captions-webvtt/styling.vtt" kind="captions" default>

50 </video>	52 </video>

OLD	NEW