third_party/WebKit/LayoutTests/media/constructors.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/constructors.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <body>	1 <body>

2 <p>Test that media constructors behave consistently.</p>	2 <p>Test that media constructors behave consistently.</p>

3 <video></video>	3 <video></video>

4 <audio></audio>	4 <audio></audio>

	5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	6 (Please avoid writing new tests using video-test.js) -->

5 <script src=video-test.js></script>	7 <script src=video-test.js></script>

6 <script>	8 <script>

7 var audioJS = new Audio();	9 var audioJS = new Audio();

8 var videoElem = document.getElementsByTagName('video')[0];	10 var videoElem = document.getElementsByTagName('video')[0];

9 var audioElem = document.getElementsByTagName('audio')[0];	11 var audioElem = document.getElementsByTagName('audio')[0];

10 testExpected("audioJS instanceof HTMLAudioElement", true);	12 testExpected("audioJS instanceof HTMLAudioElement", true);

11 testExpected("audioJS instanceof HTMLMediaElement", true);	13 testExpected("audioJS instanceof HTMLMediaElement", true);

12 testExpected("audioJS instanceof HTMLVideoElement", false);	14 testExpected("audioJS instanceof HTMLVideoElement", false);

13 testExpected("audioElem instanceof HTMLAudioElement", true);	15 testExpected("audioElem instanceof HTMLAudioElement", true);

14 testExpected("audioElem instanceof HTMLMediaElement", true);	16 testExpected("audioElem instanceof HTMLMediaElement", true);

15 testExpected("audioElem instanceof HTMLVideoElement", false);	17 testExpected("audioElem instanceof HTMLVideoElement", false);

16 testExpected("videoElem instanceof HTMLVideoElement", true);	18 testExpected("videoElem instanceof HTMLVideoElement", true);

17 testExpected("videoElem instanceof HTMLMediaElement", true);	19 testExpected("videoElem instanceof HTMLMediaElement", true);

18 testExpected("videoElem instanceof HTMLAudioElement", false);	20 testExpected("videoElem instanceof HTMLAudioElement", false);

19 endTest();	21 endTest();

20 </script>	22 </script>

OLD	NEW