third_party/WebKit/LayoutTests/http/tests/security/video-cross-origin-via-dom.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/video-cross-origin-via-dom.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/video-cross-origin-readback.html ('k') | third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <body onload="start()">	3 <body onload="start()">

	4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	5 (Please avoid writing new tests using video-test.js) -->

4 <script src=../../media-resources/video-test.js></script>	6 <script src=../../media-resources/video-test.js></script>

5 <script src=../../media-resources/media-file.js></script>	7 <script src=../../media-resources/media-file.js></script>

6 <script>	8 <script>

7 waitForEvent('error', function() {	9 waitForEvent('error', function() {

8 failTest("error: " + JSON.stringify(video.error));	10 failTest("error: " + JSON.stringify(video.error));

9 });	11 });

10	12

11 waitForEvent('playing', function() {	13 waitForEvent('playing', function() {

12 try {	14 try {

13 var ctx = document.getElementsByTagName('canvas')[0].getContext("2 d");	15 var ctx = document.getElementsByTagName('canvas')[0].getContext("2 d");

(...skipping 11 matching lines...) Expand all Loading...
25 document.body.appendChild(mediaElement);	27 document.body.appendChild(mediaElement);

26 var mediaFile = findMediaFile("video", "../../media/resources/test") ;	28 var mediaFile = findMediaFile("video", "../../media/resources/test") ;

27 var type = mimeTypeForExtension(mediaFile.split('.').pop());	29 var type = mimeTypeForExtension(mediaFile.split('.').pop());

28 video.src = "http://localhost:8080/security/resources/video-cross-or igin-allow.php?no-preflight&name=" + mediaFile + "&type=" + type;	30 video.src = "http://localhost:8080/security/resources/video-cross-or igin-allow.php?no-preflight&name=" + mediaFile + "&type=" + type;

29 video.play();	31 video.play();

30 }	32 }

31 </script>	33 </script>

32 <canvas></canvas>	34 <canvas></canvas>

33 </body>	35 </body>

34 </head>	36 </head>

OLD	NEW