third_party/WebKit/LayoutTests/http/tests/media/video-served-as-text.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/video-served-as-text.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-middle.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/video-throttled-load-metadata.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>media file served as 'text/plain'</title>	4 <title>media file served as 'text/plain'</title>

5 <script src=../../media-resources/media-file.js></script>	5 <script src=../../media-resources/media-file.js></script>

	6 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	7 (Please avoid writing new tests using video-test.js) -->

6 <script src=../../media-resources/video-test.js></script>	8 <script src=../../media-resources/video-test.js></script>

7 <script>	9 <script>

8 function loadedmetadata(evt)	10 function loadedmetadata(evt)

9 {	11 {

10 logResult(true, "loaded media file served as text");	12 logResult(true, "loaded media file served as text");

11 endTest();	13 endTest();

12 }	14 }

13	15

14 function error(evt)	16 function error(evt)

15 {	17 {

16 logResult(false, "failed trying to load media file served as tex t");	18 logResult(false, "failed trying to load media file served as tex t");

17 endTest();	19 endTest();

18 }	20 }

19	21

20 function start()	22 function start()

21 {	23 {

22 findMediaElement();	24 findMediaElement();

23	25

24 waitForEvent('loadedmetadata', loadedmetadata);	26 waitForEvent('loadedmetadata', loadedmetadata);

25 waitForEvent("error", error);	27 waitForEvent("error", error);

26 waitForEvent("loadstart");	28 waitForEvent("loadstart");

27 testExpected("video.error", null);	29 testExpected("video.error", null);

28	30

29 var movie = findMediaFile("video", "resources/test");	31 var movie = findMediaFile("video", "resources/test");

30 video.src = "http://127.0.0.1:8000/media/video-throttled-load.cg i?name=" + movie + "&throttle=99999&type=text/plain";	32 video.src = "http://127.0.0.1:8000/media/video-throttled-load.cg i?name=" + movie + "&throttle=99999&type=text/plain";

31 }	33 }

32 </script>	34 </script>

33 </head>	35 </head>

34	36

35 <body onload="start()">	37 <body onload="start()">

36 <video controls></video>	38 <video controls></video>

37 </body>	39 </body>

38 </html>	40 </html>

OLD	NEW