third_party/WebKit/LayoutTests/http/tests/media/video-query-url.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/video-query-url.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/video-play-stall-before-meta-data.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/video-referer.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

	3 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	4 (Please avoid writing new tests using video-test.js) -->

3 <script src=../../media-resources/video-test.js></script>	5 <script src=../../media-resources/video-test.js></script>

4 <script src=../../media-resources/media-file.js></script>	6 <script src=../../media-resources/media-file.js></script>

5 <script>	7 <script>

6 function loadMediaFrame()	8 function loadMediaFrame()

7 {	9 {

8 findMediaElement();	10 findMediaElement();

9	11

10 var movie = findMediaFile('video', 'test');	12 var movie = findMediaFile('video', 'test');

11 var type = mimeTypeForExtension(movie.split('.').pop());	13 var type = mimeTypeForExtension(movie.split('.').pop());

12 var frame = document.createElement('iframe');	14 var frame = document.createElement('iframe');

13	15

14 frame.width = 0;	16 frame.width = 0;

15 frame.height = 0;	17 frame.height = 0;

16 frame.addEventListener('load', function () {	18 frame.addEventListener('load', function () {

17 video.src = 'http://127.0.0.1:8000/media/resources/load-vide o.php?name=' + movie + '&type=' + type;	19 video.src = 'http://127.0.0.1:8000/media/resources/load-vide o.php?name=' + movie + '&type=' + type;

18	20

19 waitForEventAndFail('error');	21 waitForEventAndFail('error');

20 waitForEventAndEnd('canplay');	22 waitForEventAndEnd('canplay');

21 });	23 });

22	24

23 frame.src = "data:text/html,<b>test</b>";	25 frame.src = "data:text/html,<b>test</b>";

24 document.body.appendChild(frame);	26 document.body.appendChild(frame);

25 }	27 }

26 </script>	28 </script>

27 </head>	29 </head>

28	30

29 <body onload="loadMediaFrame()">	31 <body onload="loadMediaFrame()">

30 <video controls></video>	32 <video controls></video>

31 <br>	33 <br>

32 Tests that WebKit is able to open a media file specified with a query ur l.	34 Tests that WebKit is able to open a media file specified with a query ur l.

33 </body>	35 </body>

34 </html>	36 </html>

OLD	NEW