third_party/WebKit/LayoutTests/http/tests/media/video-load-twice.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/video-load-twice.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/video-load-suspend.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/video-load-with-userpass.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src=../../media-resources/media-file.js></script>	3 <script src=../../media-resources/media-file.js></script>

	4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	5 (Please avoid writing new tests using video-test.js) -->

4 <script src=../../media-resources/video-test.js></script>	6 <script src=../../media-resources/video-test.js></script>

5 <script>	7 <script>

6 var file = findMediaFile("video", "http://127.0.0.1:8000/resources/test");	8 var file = findMediaFile("video", "http://127.0.0.1:8000/resources/test");

7	9

8 function createVideo() {	10 function createVideo() {

9 var video = document.createElement("video");	11 var video = document.createElement("video");

10 document.body.appendChild(video);	12 document.body.appendChild(video);

11 findMediaElement();	13 findMediaElement();

12 waitForEvent('loadedmetadata');	14 waitForEvent('loadedmetadata');

13 waitForEvent('loadeddata');	15 waitForEvent('loadeddata');

(...skipping 10 matching lines...) Expand all Loading...
24 function init() {	26 function init() {

25 createVideo();	27 createVideo();

26 waitForEventOnce('canplaythrough', firstCanPlayThrough);	28 waitForEventOnce('canplaythrough', firstCanPlayThrough);

27 run("video.src = file");	29 run("video.src = file");

28 }	30 }

29 </script>	31 </script>

30 </head>	32 </head>

31 <body onload="init()">	33 <body onload="init()">

32 </body>	34 </body>

33 </html>	35 </html>

OLD	NEW