third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/video-cancel-load.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 </head>	3 </head>

4 <body onload="loadCookie()">	4 <body onload="loadCookie()">

5 <video id="video"></video>	5 <video id="video"></video>

	6 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	7 (Please avoid writing new tests using video-test.js) -->

6 <script src=../../media-resources/video-test.js></script>	8 <script src=../../media-resources/video-test.js></script>

7 <script src=../../media-resources/media-file.js></script>	9 <script src=../../media-resources/media-file.js></script>

8 <script>	10 <script>

9 if (window.testRunner) {	11 if (window.testRunner) {

10 testRunner.dumpAsText();	12 testRunner.dumpAsText();

11 testRunner.setAlwaysAcceptCookies(true);	13 testRunner.setAlwaysAcceptCookies(true);

12 testRunner.waitUntilDone();	14 testRunner.waitUntilDone();

13 }	15 }

14	16

15 function loadCookie () {	17 function loadCookie () {

(...skipping 13 matching lines...) Expand all Loading...
29 }	31 }

30	32

31 waitForEvent("canplay", function () {	33 waitForEvent("canplay", function () {

32 if (window.testRunner)	34 if (window.testRunner)

33 window.testRunner.notifyDone();	35 window.testRunner.notifyDone();

34 } );	36 } );

35 </script>	37 </script>

36 Tests that the media player will send the relevant cookies when requesting the m edia file.<br/>	38 Tests that the media player will send the relevant cookies when requesting the m edia file.<br/>

37 </body>	39 </body>

38 </html>	40 </html>

OLD	NEW