third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/text-served-as-text.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <video></video>	1 <video></video>

2 <p>Test that removing a media element from the tree while loading does not crash .</p>	2 <p>Test that removing a media element from the tree while loading does not crash .</p>

3 <script src=../../media-resources/media-file.js></script>	3 <script src=../../media-resources/media-file.js></script>

	4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	5 (Please avoid writing new tests using video-test.js) -->

4 <script src=../../media-resources/video-test.js></script>	6 <script src=../../media-resources/video-test.js></script>

5 <script>	7 <script>

6 waitForEvent('loadedmetadata', function () {	8 waitForEvent('loadedmetadata', function () {

7 run("document.body.removeChild(video)");	9 run("document.body.removeChild(video)");

8 endTestLater();	10 endTestLater();

9 } );	11 } );

10	12

11 // Find a supported media file.	13 // Find a supported media file.

12 var mediaFile = findMediaFile("video", "content/test");	14 var mediaFile = findMediaFile("video", "content/test");

13 var mimeType = mimeTypeForFile(mediaFile);	15 var mimeType = mimeTypeForFile(mediaFile);

14	16

15 video.src = "http://127.0.0.1:8000/resources/load-and-stall.cgi?name=../../../me dia/" + mediaFile + "&mimeType=" + mimeType + "&stallAt=100000";	17 video.src = "http://127.0.0.1:8000/resources/load-and-stall.cgi?name=../../../me dia/" + mediaFile + "&mimeType=" + mimeType + "&stallAt=100000";

16 </script>	18 </script>

OLD	NEW