third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist-crash.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>PDF file served as 'application/pdf'</title>	4 <title>PDF file served as 'application/pdf'</title>

	5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	6 (Please avoid writing new tests using video-test.js) -->

5 <script src=../../media-resources/video-test.js></script>	7 <script src=../../media-resources/video-test.js></script>

6 <script>	8 <script>

7 function loadedmetadata(evt)	9 function loadedmetadata(evt)

8 {	10 {

9 logResult(false, "loaded PDF file served as PDF");	11 logResult(false, "loaded PDF file served as PDF");

10 endTest();	12 endTest();

11 }	13 }

12	14

13 function error(evt)	15 function error(evt)

14 {	16 {

15 logResult(true, "failed trying to load PDF file served as PDF");	17 logResult(true, "failed trying to load PDF file served as PDF");

16 endTest();	18 endTest();

17 }	19 }

18	20

19 function start()	21 function start()

20 {	22 {

21 findMediaElement();	23 findMediaElement();

22	24

23 waitForEvent('loadedmetadata', loadedmetadata);	25 waitForEvent('loadedmetadata', loadedmetadata);

24 waitForEvent("error", error);	26 waitForEvent("error", error);

25 waitForEvent("loadstart");	27 waitForEvent("loadstart");

26 testExpected("video.error", null);	28 testExpected("video.error", null);

27	29

28 var movie = "resources/test.pdf";	30 var movie = "resources/test.pdf";

29 video.src = "http://127.0.0.1:8000/media/video-throttled-load.cg i?name=" + movie + "&throttle=99999&type=application/pdf";	31 video.src = "http://127.0.0.1:8000/media/video-throttled-load.cg i?name=" + movie + "&throttle=99999&type=application/pdf";

30 }	32 }

31 </script>	33 </script>

32 </head>	34 </head>

33	35

34 <body onload="start()">	36 <body onload="start()">

35 <video controls></video>	37 <video controls></video>

36 </body>	38 </body>

37 </html>	39 </html>

OLD	NEW