third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-gc-after-decode-error-crash.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-gc-after-decode-error-crash.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-htmlmediaelement-lifetime.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

	4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	5 (Please avoid writing new tests using video-test.js) -->

4 <script src="../../media-resources/video-test.js"></script>	6 <script src="../../media-resources/video-test.js"></script>

5 </head>	7 </head>

6 <body>	8 <body>

7 <p>Verifies that a MediaSource decode error followed by a gc() and page reload does not trigger a crash.</p>	9 <p>Verifies that a MediaSource decode error followed by a gc() and page reload does not trigger a crash.</p>

8 <video></video>	10 <video></video>

9 <script>	11 <script>

10 function onSourceOpen(e)	12 function onSourceOpen(e)

11 {	13 {

12 consoleWrite("onSourceOpen");	14 consoleWrite("onSourceOpen");

13 var ms = e.target;	15 var ms = e.target;

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51	53

52 (function()	54 (function()

53 {	55 {

54 var ms = new MediaSource();	56 var ms = new MediaSource();

55 ms.addEventListener("sourceopen", onSourceOpen);	57 ms.addEventListener("sourceopen", onSourceOpen);

56 document.querySelector("video").src = URL.createObjectURL(ms);	58 document.querySelector("video").src = URL.createObjectURL(ms);

57 })();	59 })();

58 </script>	60 </script>

59 </body>	61 </body>

60 </html>	62 </html>

OLD	NEW