third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/media-document.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-gc-after-decode-error-crash.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

	4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	5 (Please avoid writing new tests using video-test.js) -->

4 <script src="/media-resources/video-test.js"></script>	6 <script src="/media-resources/video-test.js"></script>

5 </head>	7 </head>

6 <body>	8 <body>

7 <video autoplay controls="controls" id='vid'></video>	9 <video autoplay controls="controls" id='vid'></video>

8 <p>Tests that sourceopen event fires even if garbage collection happens between setting video.src & the sourceopen event.</p>	10 <p>Tests that sourceopen event fires even if garbage collection happens between setting video.src & the sourceopen event.</p>

9 <script type="text/javascript">	11 <script type="text/javascript">

10 var sourceOpened = false;	12 var sourceOpened = false;

11	13

12 function createMediaSourceURL()	14 function createMediaSourceURL()

13 {	15 {

(...skipping 25 matching lines...) Expand all Loading...
39 consoleWrite("Running garbage collector.");	41 consoleWrite("Running garbage collector.");

40 gc();	42 gc();

41	43

42 consoleWrite("Setting video.src to object URL.");	44 consoleWrite("Setting video.src to object URL.");

43 video.src = url;	45 video.src = url;

44 }	46 }

45 start();	47 start();

46 </script>	48 </script>

47 </body>	49 </body>

48 </html>	50 </html>

OLD	NEW