DataView implementation.

src/objects-debug.cc

Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index ca42383cbd41f9f9f6eaf59f575d8ed9eb11f94f..848072856740b19f7e40538eaed248dce2970aad 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -207,6 +207,9 @@ void HeapObject::HeapObjectVerify() {
     case JS_TYPED_ARRAY_TYPE:
       JSTypedArray::cast(this)->JSTypedArrayVerify();
       break;
+    case JS_DATA_VIEW_TYPE:
+      JSDataView::cast(this)->JSDataViewVerify();
+      break;
 
 #define MAKE_STRUCT_CASE(NAME, Name, name) \
   case NAME##_TYPE:                        \
@@ -761,8 +764,7 @@ void JSArrayBuffer::JSArrayBufferVerify() {
 }
 
 
-void JSTypedArray::JSTypedArrayVerify() {
-  CHECK(IsJSTypedArray());

[rossberg, 2013/06/21 08:44:01]

Why not CHECK(IsJSArrayBufferView())?

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+void JSArrayBufferView::JSArrayBufferViewVerify() {
   JSObjectVerify();
   VerifyPointer(buffer());
   CHECK(buffer()->IsJSArrayBuffer() || buffer()->IsUndefined());
@@ -774,7 +776,11 @@ void JSTypedArray::JSTypedArrayVerify() {
   VerifyPointer(byte_length());
   CHECK(byte_length()->IsSmi() || byte_length()->IsHeapNumber()
         || byte_length()->IsUndefined());
+}
 

[rossberg, 2013/06/21 08:44:01]

Nit: 2 empty lines

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+void JSTypedArray::JSTypedArrayVerify() {
+  CHECK(IsJSTypedArray());
+  JSArrayBufferViewVerify();
   VerifyPointer(length());
   CHECK(length()->IsSmi() || length()->IsHeapNumber()
         || length()->IsUndefined());
@@ -783,6 +789,12 @@ void JSTypedArray::JSTypedArrayVerify() {
 }
 
 
+void JSDataView::JSDataViewVerify() {
+  CHECK(IsJSDataView());
+  JSArrayBufferViewVerify();
+}
+
+
 void Foreign::ForeignVerify() {
   CHECK(IsForeign());
 }