Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: src/api.cc

Issue 17153011: DataView implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 579af7aebd442e4c346d1bc65dcc56d75b1b8073..7ae75bacadbeffd49096986312f0a1b8e9917f14 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6182,11 +6182,17 @@ void v8::ArrayBuffer::Neuter() {
LOG_API(obj->GetIsolate(), "v8::ArrayBuffer::Neuter()");
ENTER_V8(isolate);
- for (i::Handle<i::Object> array_obj(obj->weak_first_array(), isolate);
- !array_obj->IsUndefined();) {
- i::Handle<i::JSTypedArray> typed_array(i::JSTypedArray::cast(*array_obj));
- typed_array->Neuter();
- array_obj = i::handle(typed_array->weak_next(), isolate);
+ for (i::Handle<i::Object> view_obj(obj->weak_first_view(), isolate);
+ !view_obj->IsUndefined();) {
+ i::Handle<i::JSArrayBufferView> view(i::JSArrayBufferView::cast(*view_obj));
+ if (view->IsJSTypedArray()) {
+ i::JSTypedArray::cast(*view)->Neuter();
+ } else if (view->IsJSDataView()) {
+ i::JSDataView::cast(*view)->Neuter();
+ } else {
+ UNREACHABLE();
+ }
+ view_obj = i::handle(view->weak_next(), isolate);
}
obj->Neuter();
}
@@ -6286,8 +6292,8 @@ i::Handle<i::JSTypedArray> NewTypedArray(
obj->set_buffer(*buffer);
- obj->set_weak_next(buffer->weak_first_array());
- buffer->set_weak_first_array(*obj);
+ obj->set_weak_next(buffer->weak_first_view());
+ buffer->set_weak_first_view(*obj);
i::Handle<i::Object> byte_offset_object = isolate->factory()->NewNumber(
static_cast<double>(byte_offset));
« no previous file with comments | « include/v8.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698