DataView implementation.

test/mjsunit/harmony/dataview-accessors.js

+// Copyright 2013 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+//       notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+//       copyright notice, this list of conditions and the following
+//       disclaimer in the documentation and/or other materials provided
+//       with the distribution.
+//     * Neither the name of Google Inc. nor the names of its
+//       contributors may be used to endorse or promote products derived
+//       from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// These tests are adapted from Khronos DataView tests
+
+var intArray1 = [0, 1, 2, 3, 100, 101, 102, 103, 128, 129, 130, 131, 252, 253, 254, 255];

[rossberg, 2013/06/21 08:44:01]

Nit: line length

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+var intArray2 = [31, 32, 33, 0, 1, 2, 3, 100, 101, 102, 103, 128, 129, 130, 131, 252, 253, 254, 255];
+var initialArray = [204, 204, 204, 204, 204, 204, 204, 204, 204, 204, 204, 204, 204, 204, 204, 204];
+
+var arayBuffer = null;
+var view = null;
+var viewStart = 0;
+var viewLength = 0;
+
+function getElementSize(func)
+{

[rossberg, 2013/06/21 08:44:01]

Nit: style violation (here and below)

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+    switch (func) {

[rossberg, 2013/06/21 08:44:01]

Nit: indentation style

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+    case "Int8":
+    case "Uint8":
+        return 1;
+    case "Int16":
+    case "Uint16":
+        return 2;
+    case "Int32":
+    case "Uint32":
+    case "Float32":
+        return 4;
+    case "Float64":
+        return 8;
+    default:
+        debug("Should not reached");

[rossberg, 2013/06/21 08:44:01]

I think we have assertUnreachable()

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+    }
+}
+
+function checkGet(func, index, expected, littleEndian)
+{
+    function doGet() {
+      return view["get" + func](index, littleEndian);
+    }
+    if (index < 0) index = 0;

[rossberg, 2013/06/21 08:44:01]

I don't understand. What use is runNegativeIndexTest below if you correct it
anyway?

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

[rossberg, 2013/06/21 12:25:53]

This doesn't seem to be fixed.

[Dmitry Lomov (no reviews), 2013/06/21 12:39:20]

No it is fixed - see the latest version of this file.

+    if (index + getElementSize(func) - 1 < view.byteLength)
+        assertSame(expected, doGet());
+    else
+        assertThrows(doGet, RangeError);
+}
+
+function checkSet(func, index, value, littleEndian)
+{
+    function doSet() {
+      view["set" + func](index, value, littleEndian);
+    }
+    if (index < 0) index = 0;
+    if (index >= 0 && index + getElementSize(func) - 1 < view.byteLength) {
+        assertSame(undefined, doSet());
+        checkGet(func, index, value, littleEndian);
+    } else

[rossberg, 2013/06/21 08:44:01]

Nit: style guide wants braces consistently on branches

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+        assertThrows(doSet, RangeError);
+}
+
+function test(isTestingGet, func, index, value, littleEndian)
+{
+    if (isTestingGet)
+        checkGet(func, index, value, littleEndian);
+     else

[rossberg, 2013/06/21 08:44:01]

Nit: odd indentation

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+        checkSet(func, index, value, littleEndian);
+}
+
+function createDataView(array, frontPaddingNum, littleEndian, start, length)
+{
+    if (!littleEndian)
+        array.reverse();
+    var paddingArray = new Array(frontPaddingNum);
+    arrayBuffer = (new Uint8Array(paddingArray.concat(array))).buffer;
+    viewStart = (start != undefined) ? start : 0;

[rossberg, 2013/06/21 08:44:01]

Shouldn't the DataView constructor do all the defaulting for you?

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done.

+    viewLength = (length != undefined) ? length : arrayBuffer.byteLength - viewStart;

[rossberg, 2013/06/21 08:44:01]

Nit: line length

[Dmitry Lomov (no reviews), 2013/06/21 11:32:10]

Done by removing line

+    view = new DataView(arrayBuffer, viewStart, viewLength);
+    if (!littleEndian)
+        array.reverse(); // restore the array.
+}
+
+function runIntegerTestCases(isTestingGet, array, start, length)
+{
+    createDataView(array, 0, true, start, length);
+
+    test(isTestingGet, "Int8", 0, 0);
+    test(isTestingGet, "Int8", 8, -128);
+    test(isTestingGet, "Int8", 15, -1);
+
+    test(isTestingGet, "Uint8", 0, 0);
+    test(isTestingGet, "Uint8", 8, 128);
+    test(isTestingGet, "Uint8", 15, 255);
+
+    // Little endian.
+    test(isTestingGet, "Int16", 0, 256, true);
+    test(isTestingGet, "Int16", 5, 26213, true);
+    test(isTestingGet, "Int16", 9, -32127, true);
+    test(isTestingGet, "Int16", 14, -2, true);
+
+    // Big endian.
+    test(isTestingGet, "Int16", 0, 1);
+    test(isTestingGet, "Int16", 5, 25958);
+    test(isTestingGet, "Int16", 9, -32382);
+    test(isTestingGet, "Int16", 14, -257);
+
+    // Little endian.
+    test(isTestingGet, "Uint16", 0, 256, true);
+    test(isTestingGet, "Uint16", 5, 26213, true);
+    test(isTestingGet, "Uint16", 9, 33409, true);
+    test(isTestingGet, "Uint16", 14, 65534, true);
+
+    // Big endian.
+    test(isTestingGet, "Uint16", 0, 1);
+    test(isTestingGet, "Uint16", 5, 25958);
+    test(isTestingGet, "Uint16", 9, 33154);
+    test(isTestingGet, "Uint16", 14, 65279);
+
+    // Little endian.
+    test(isTestingGet, "Int32", 0, 50462976, true);
+    test(isTestingGet, "Int32", 3, 1717920771, true);
+    test(isTestingGet, "Int32", 6, -2122291354, true);
+    test(isTestingGet, "Int32", 9, -58490239, true);
+    test(isTestingGet, "Int32", 12,-66052, true);
+
+    // Big endian.
+    test(isTestingGet, "Int32", 0, 66051);
+    test(isTestingGet, "Int32", 3, 56911206);
+    test(isTestingGet, "Int32", 6, 1718059137);
+    test(isTestingGet, "Int32", 9, -2122152964);
+    test(isTestingGet, "Int32", 12, -50462977);
+
+    // Little endian.
+    test(isTestingGet, "Uint32", 0, 50462976, true);
+    test(isTestingGet, "Uint32", 3, 1717920771, true);
+    test(isTestingGet, "Uint32", 6, 2172675942, true);
+    test(isTestingGet, "Uint32", 9, 4236477057, true);
+    test(isTestingGet, "Uint32", 12,4294901244, true);
+
+    // Big endian.
+    test(isTestingGet, "Uint32", 0, 66051);
+    test(isTestingGet, "Uint32", 3, 56911206);
+    test(isTestingGet, "Uint32", 6, 1718059137);
+    test(isTestingGet, "Uint32", 9, 2172814332);
+    test(isTestingGet, "Uint32", 12, 4244504319);
+}
+
+function testFloat(isTestingGet, func, array, start, expected)
+{
+    // Little endian.
+    createDataView(array, 0, true, start);
+    test(isTestingGet, func, 0, expected, true);
+    createDataView(array, 3, true, start);
+    test(isTestingGet, func, 3, expected, true);
+    createDataView(array, 7, true, start);
+    test(isTestingGet, func, 7, expected, true);
+    createDataView(array, 10, true, start);
+    test(isTestingGet, func, 10, expected, true);
+
+    // Big endian.
+    createDataView(array, 0, false);
+    test(isTestingGet, func, 0, expected, false);
+    createDataView(array, 3, false);
+    test(isTestingGet, func, 3, expected, false);
+    createDataView(array, 7, false);
+    test(isTestingGet, func, 7, expected, false);
+    createDataView(array, 10, false);
+    test(isTestingGet, func, 10, expected, false);
+}
+
+function runFloatTestCases(isTestingGet, start)
+{
+    testFloat(isTestingGet, "Float32",
+        isTestingGet ? [0, 0, 32, 65] : initialArray, start, 10);
+
+    testFloat(isTestingGet, "Float32",
+        isTestingGet ? [164, 112, 157, 63] : initialArray,
+        start, 1.2300000190734863);
+    testFloat(isTestingGet, "Float32",
+        isTestingGet ? [95, 53, 50, 199] : initialArray,
+        start, -45621.37109375);
+    testFloat(isTestingGet, "Float32",
+        isTestingGet ? [255, 255, 255, 127] : initialArray,
+        start, NaN);
+    testFloat(isTestingGet, "Float32",
+        isTestingGet ? [255, 255, 255, 255] : initialArray,
+        start, -NaN);
+
+    testFloat(isTestingGet, "Float64",
+        isTestingGet ? [0, 0, 0, 0, 0, 0, 36, 64] : initialArray,
+        start, 10);
+    testFloat(isTestingGet, "Float64",
+        isTestingGet ? [174, 71, 225, 122, 20, 174, 243, 63] : initialArray,
+        start, 1.23);
+    testFloat(isTestingGet, "Float64",
+        isTestingGet ? [181, 55, 248, 30, 242, 179, 87, 193] : initialArray,
+        start, -6213576.4839);
+    testFloat(isTestingGet, "Float64",
+        isTestingGet ? [255, 255, 255, 255, 255, 255, 255, 127] : initialArray,
+        start, NaN);
+    testFloat(isTestingGet, "Float64",
+        isTestingGet ? [255, 255, 255, 255, 255, 255, 255, 255] : initialArray,
+        start, -NaN);
+}
+
+function runNegativeIndexTests(isTestingGet)
+{
+    createDataView(intArray1, 0, true, 0, 16);
+
+    test(isTestingGet, "Int8", -1, 0);
+    test(isTestingGet, "Int8", -2, 0);
+
+    test(isTestingGet, "Uint8", -1, 0);
+    test(isTestingGet, "Uint8", -2, 0);
+
+    test(isTestingGet, "Int16", -1, 1);
+    test(isTestingGet, "Int16", -2, 1);
+    test(isTestingGet, "Int16", -3, 1);
+
+    test(isTestingGet, "Uint16", -1, 1);
+    test(isTestingGet, "Uint16", -2, 1);
+    test(isTestingGet, "Uint16", -3, 1);
+
+    test(isTestingGet, "Int32", -1, 66051);
+    test(isTestingGet, "Int32", -3, 66051);
+    test(isTestingGet, "Int32", -5, 66051);
+
+    test(isTestingGet, "Uint32", -1, 66051);
+    test(isTestingGet, "Uint32", -3, 66051);
+    test(isTestingGet, "Uint32", -5, 66051);
+
+    createDataView([0, 0, 0, 0, 0, 0, 0, 0], 0, true, 0, 8);
+
+    test(isTestingGet, "Float32", -1, 0);
+    test(isTestingGet, "Float32", -3, 0);
+    test(isTestingGet, "Float32", -5, 0);
+
+    test(isTestingGet, "Float64", -1, 0);
+    test(isTestingGet, "Float64", -5, 0);
+    test(isTestingGet, "Float64", -9, 0);
+}
+
+
+function TestGetters()
+{
+    runIntegerTestCases(true, intArray1, 0, 16);
+    runFloatTestCases(true, 0);
+
+    runIntegerTestCases(true, intArray2, 3, 2);
+    runFloatTestCases(true, 3);
+
+    runNegativeIndexTests(true);
+}
+
+function TestSetters()
+{
+    runIntegerTestCases(false, initialArray, 0, 16);
+    runFloatTestCases(false);
+
+    runIntegerTestCases(false, initialArray, 3, 2);
+    runFloatTestCases(false, 7);
+
+    runNegativeIndexTests(false);
+
+}
+
+TestGetters();
+TestSetters();
+
+function TestGeneralAccessors() {
+  var a = new DataView(new ArrayBuffer(256));
+  function CheckAccessor(name) {
+    var f = a[name];
+    f.call(a, 0, 0); // should not throw
+    assertThrows(function() { f.call({}, 0, 0); }, TypeError);
+  }
+  CheckAccessor("getUint8");
+  CheckAccessor("setUint8");
+  CheckAccessor("getInt8");
+  CheckAccessor("setInt8");
+  CheckAccessor("getUint16");
+  CheckAccessor("setUint16");
+  CheckAccessor("getInt16");
+  CheckAccessor("setInt16");
+  CheckAccessor("getUint32");
+  CheckAccessor("setUint32");
+  CheckAccessor("getInt32");
+  CheckAccessor("setInt32");
+  CheckAccessor("getFloat32");
+  CheckAccessor("setFloat32");
+  CheckAccessor("getFloat64");
+  CheckAccessor("setFloat64");
+}
+
+TestGeneralAccessors();