Chrome Frame turndown prompt.

chrome_frame/test/policy_settings_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/at_exit.h"
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 12 matching lines @@
 // A best effort way to zap CF policy entries that may be in the registry.
 void DeleteChromeFramePolicyEntries(HKEY root) {
   RegKey key;
   if (key.Open(root, policy::kRegistryChromePolicyKey,
                KEY_ALL_ACCESS) == ERROR_SUCCESS) {
     key.DeleteValue(
         ASCIIToWide(policy::key::kChromeFrameRendererSettings).c_str());
     key.DeleteKey(ASCIIToWide(policy::key::kRenderInChromeFrameList).c_str());
     key.DeleteKey(ASCIIToWide(policy::key::kRenderInHostList).c_str());
     key.DeleteKey(ASCIIToWide(policy::key::kChromeFrameContentTypes).c_str());
-    key.DeleteKey(ASCIIToWide(policy::key::kApplicationLocaleValue).c_str());
+    key.DeleteValue(ASCIIToWide(policy::key::kApplicationLocaleValue).c_str());
+    key.DeleteValue(
+        ASCIIToWide(policy::key::kSuppressChromeFrameTurndownPrompt).c_str());
   }
 }
 
 bool InitializePolicyKey(HKEY policy_root, RegKey* policy_key) {
   EXPECT_EQ(ERROR_SUCCESS, policy_key->Create(policy_root,
       policy::kRegistryChromePolicyKey, KEY_ALL_ACCESS));
   return policy_key->Valid();
 }
 
 void WritePolicyList(RegKey* policy_key,
@@ skipping 53 matching lines @@
   RegKey policy_key;
   if (!InitializePolicyKey(policy_root, &policy_key))
     return false;
 
   std::wstring policy_name_str(ASCIIToWide(policy_name));
   EXPECT_EQ(ERROR_SUCCESS,
       policy_key.WriteValue(policy_name_str.c_str(), value));
   return true;
 }
 
+bool SetCFPolicyBool(HKEY policy_root,
+                     const char* policy_name,
+                     bool value) {
+  RegKey policy_key;
+  if (!InitializePolicyKey(policy_root, &policy_key))
+    return false;
+
+  std::wstring policy_name_str(ASCIIToWide(policy_name));
+  EXPECT_EQ(ERROR_SUCCESS,
+            policy_key.WriteValue(policy_name_str.c_str(), value ? 1U : 0U));
+  return true;
+}

[robertshield, 2013/06/19 23:36:33]

The return value for this function is never used, but were it to be, I would
expect it to return policy_key.WriteValue() == ERROR_SUCCESS

[grt (UTC plus 2), 2013/06/20 19:55:29]

Rejiggered.

+
 }  // end namespace
 
 class PolicySettingsTest : public testing::Test {
  protected:
   void SetUp() {
     ResetPolicySettings();
   }
 
   void TearDown() {
   }
@@ skipping 122 matching lines @@
 
     base::FilePath program_path(FILE_PATH_LITERAL("my_chrome.exe"));
     CommandLine new_cmd_line(program_path);
     new_cmd_line.AppendArguments(additional_params, false);
     EXPECT_NE(new_cmd_line.GetProgram(), additional_params.GetProgram());
     EXPECT_TRUE(new_cmd_line.HasSwitch(switches::kDisableWebKitMediaSource));
 
     DeleteChromeFramePolicyEntries(root[i]);
   }
 }
+
+TEST_F(PolicySettingsTest, SuppressTurndownPrompt) {
+  EXPECT_FALSE(PolicySettings::GetInstance()->suppress_turndown_prompt());
+
+  HKEY root[] = { HKEY_LOCAL_MACHINE, HKEY_CURRENT_USER };
+  for (int i = 0; i < arraysize(root); ++i) {
+    SetCFPolicyBool(root[i], policy::key::kSuppressChromeFrameTurndownPrompt,
+                    true);
+    ResetPolicySettings();
+    EXPECT_TRUE(PolicySettings::GetInstance()->suppress_turndown_prompt());
+
+    DeleteChromeFramePolicyEntries(root[i]);
+  }
+}