src/crankshaft/x87/lithium-codegen-x87.cc - Issue 1715263002: [crankshaft][X87] Fix Math.min(-0, -0)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x87/lithium-codegen-x87.cc

Issue 1715263002: [crankshaft][X87] Fix Math.min(-0, -0) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x87/lithium-codegen-x87.cc

diff --git a/src/crankshaft/x87/lithium-codegen-x87.cc b/src/crankshaft/x87/lithium-codegen-x87.cc

index 6a80143ad36cb59d1bfd7446fac022e84aaa5b8a..a8f22be732521e0f1c6546a8a312cf7decc58d07 100644

--- a/src/crankshaft/x87/lithium-codegen-x87.cc

+++ b/src/crankshaft/x87/lithium-codegen-x87.cc

@@ -2080,7 +2080,7 @@ void LCodeGen::DoMathMinMax(LMathMinMax* instr) {

__ fstp_s(MemOperand(esp, 0));

__ fstp_s(MemOperand(esp, kPointerSize));

__ pop(scratch_reg);

- __ xor_(MemOperand(esp, 0), scratch_reg);

+ __ or_(MemOperand(esp, 0), scratch_reg);

X87Mov(left_reg, MemOperand(esp, 0), kX87FloatOperand);

__ pop(scratch_reg); // restore esp

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »