Stop using the old-style profile names when using --new-profile-management

chrome/browser/profiles/profiles_state.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profiles_state.h"
 
 #include "base/files/file_path.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 32 matching lines @@
       default_profile_dir.AppendASCII(chrome::kInitialProfile);
   return default_profile_dir;
 }
 
 void RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterStringPref(prefs::kProfileLastUsed, std::string());
   registry->RegisterIntegerPref(prefs::kProfilesNumCreated, 1);
   registry->RegisterListPref(prefs::kProfilesLastActive);
 }
 
-base::string16 GetActiveProfileDisplayName(Browser* browser) {
-  base::string16 profile_name;
-  Profile* profile = browser->profile();
+base::string16 GetAvatarButtonDisplayNameForProfile(Profile* profile) {
+  base::string16 display_name;
 
   if (profile->IsGuestSession()) {
-    profile_name = l10n_util::GetStringUTF16(IDS_GUEST_PROFILE_NAME);
+    display_name = l10n_util::GetStringUTF16(IDS_GUEST_PROFILE_NAME);
   } else {
     ProfileInfoCache& cache =
         g_browser_process->profile_manager()->GetProfileInfoCache();
     size_t index = cache.GetIndexOfProfileWithPath(profile->GetPath());
-    if (index != std::string::npos)
-      profile_name = cache.GetNameOfProfileAtIndex(index);
+
+    if (index == std::string::npos)

[rpetterson, 2014/02/20 21:41:32]

shouldn't this be at least 0?

[noms (inactive), 2014/02/24 22:35:06]

Not always. GetIndexOfProfile returns std::string::npos if it can't find a
profile with that path in the ProfileInfoCache. :(

On 2014/02/20 21:41:32, rpetterson wrote:

+      return l10n_util::GetStringUTF16(IDS_SINGLE_PROFILE_DISPLAY_NAME);
+
+    // Using the --new-profile-management flag, there's a couple of rules
+    // about what the avatar button displays. If there's a single, local
+    // profile, with a default name, it should display
+    // IDS_SINGLE_PROFILE_DISPLAY_NAME. If this is a signed in profile, or
+    // the user has edited the profile name, it should display the actual
+    // name of the profile. In all other cases, it should also display the
+    // actual name of the profile.
+    base::string16 profile_name = cache.GetNameOfProfileAtIndex(index);
+    bool has_default_name = profile_name.find(l10n_util::GetStringFUTF16(
+        IDS_NEW_NUMBERED_PROFILE_NAME, base::string16())) != std::string::npos;
+
+    if (cache.GetNumberOfProfiles() == 1 && has_default_name &&
+        cache.GetUserNameOfProfileAtIndex(index).empty()) {
+      display_name = l10n_util::GetStringUTF16(IDS_SINGLE_PROFILE_DISPLAY_NAME);
+    } else {
+      display_name = profile_name;
+    }
   }
-  return profile_name;
+  return display_name;
 }
 
 void UpdateProfileName(Profile* profile,
                        const base::string16& new_profile_name) {
   ProfileInfoCache& cache =
         g_browser_process->profile_manager()->GetProfileInfoCache();
   base::FilePath profile_file_path = profile->GetPath();
   size_t profile_index = cache.GetIndexOfProfileWithPath(profile_file_path);
 
   if ((new_profile_name ==
@@ skipping 35 matching lines @@
 
   return accounts;
 }
 
 bool IsRegularOrGuestSession(Browser* browser) {
   Profile* profile = browser->profile();
   return profile->IsGuestSession() || !profile->IsOffTheRecord();
 }
 
 }  // namespace profiles