third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h - Issue 1715203002: Stop async spellchecker before running the leak detector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Issue 1715203002: Stop async spellchecker before running the leak detector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + parameterize WebLeakDetector over WebFrames instead Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

index 13dd1c0888b897d5d555ae571da74f57849a65bc..40bcdf9a82f4d6f61fa7a03418e88df383d163df 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

@@ -90,6 +90,14 @@ public:

// Exposed for testing only

SpellCheckRequester& spellCheckRequester() const { return *m_spellCheckRequester; }

+ // The leak detector will report leaks should queued requests be posted

+ // while it GCs repeatedly, as the requests keep their associated element

+ // alive.

+ //

+ // Hence allow the leak detector to effectively stop the spell checker to

+ // ensure leak reporting stability.

+ void prepareForLeakDetection();

private:

explicit SpellChecker(LocalFrame&);