Do not pop up Files app, when the recovery tool is running.

Do not pop up Files app, when the recovery tool is running.

This patch whitelists the recovery tool, so the Files app doesn't pop up when a USB/SD is inserted. This is a temporary solution for M34.

TEST=Tested manually on Pixel.
BUG=341711
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252288

[mtomasz, 2014-02-19 08:03:46]

@kinaba: PTAL. Thanks.

[kinaba, 2014-02-19 09:10:20]

lgtm+nit

https://codereview.chromium.org/171513005/diff/1/chrome/browser/chromeos/exte...
File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right):

https://codereview.chromium.org/171513005/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/event_router.cc:734: // running.
The comment "Also, do not show Files app, if the recovery tool is running." is
already written few lines above.

[mtomasz, 2014-02-19 09:37:47]

https://codereview.chromium.org/171513005/diff/1/chrome/browser/chromeos/exte...
File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right):

https://codereview.chromium.org/171513005/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/event_router.cc:734: // running.
On 2014/02/19 09:10:20, kinaba wrote:
> The comment "Also, do not show Files app, if the recovery tool is running." is
> already written few lines above.

Done.

[mtomasz, 2014-02-19 09:37:59]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-02-19 09:38:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/171513005/60001

[commit-bot: I haz the power, 2014-02-19 10:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 10:39:12]

Retried try job too often on linux_chromeos for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, check_deps2git, chromeos_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
dbus_unittests, device_unittests, events_unittests, google_apis_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
keyboard_unittests, media_unittests, net_unittests, ppapi_unittests,
printing_unittests, sandbox_linux_unittests, sql_unittests, sync_unit_tests,
unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[mtomasz, 2014-02-19 12:18:45]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-02-19 12:19:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/171513005/60001

[commit-bot: I haz the power, 2014-02-19 13:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 13:37:56]

Retried try job too often on linux_chromeos for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, check_deps2git, chromeos_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
dbus_unittests, device_unittests, events_unittests, google_apis_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
keyboard_unittests, media_unittests, net_unittests, ppapi_unittests,
printing_unittests, sandbox_linux_unittests, sql_unittests, sync_unit_tests,
unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[mtomasz, 2014-02-20 00:11:04]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2014-02-20 00:13:08]

On 2014/02/20 00:11:04, mtomasz wrote:
> The CQ bit was checked by mailto:mtomasz@chromium.org

Strange. Compiles locally.

[commit-bot: I haz the power, 2014-02-20 00:14:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/171513005/60001

[kinaba, 2014-02-20 00:16:30]

On 2014/02/20 00:13:08, mtomasz wrote:
> On 2014/02/20 00:11:04, mtomasz wrote:
> > The CQ bit was checked by mailto:mtomasz@chromium.org
> 
> Strange. Compiles locally.

Looks like a recent change:
http://src.chromium.org/viewvc/chrome?view=revision&revision=251958

[mtomasz, 2014-02-20 01:48:08]

On 2014/02/20 00:16:30, kinaba wrote:
> On 2014/02/20 00:13:08, mtomasz wrote:
> > On 2014/02/20 00:11:04, mtomasz wrote:
> > > The CQ bit was checked by mailto:mtomasz@chromium.org
> > 
> > Strange. Compiles locally.
> 
> Looks like a recent change:
> http://src.chromium.org/viewvc/chrome?view=revision&revision=251958

Thanks! I've rebased and simplified a little.

[mtomasz, 2014-02-20 01:48:24]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-02-20 02:27:36]

Failed to trigger a try job on linux_chromeos
HTTP Error 400: Bad Request

[mtomasz, 2014-02-20 02:27:54]

The CQ bit was unchecked by mtomasz@chromium.org

[mtomasz, 2014-02-20 02:27:55]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-02-20 02:31:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/171513005/450001

[commit-bot: I haz the power, 2014-02-20 05:20:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/171513005/450001

[commit-bot: I haz the power, 2014-02-20 09:20:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/171513005/450001

[commit-bot: I haz the power, 2014-02-20 12:36:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/171513005/450001

[commit-bot: I haz the power, 2014-02-20 17:25:12]

Change committed as 252288