Issue 1715123003: - Add DEBUG_ONLY and NOT_IN_PRODUCT macros.

Issue 1715123003: - Add DEBUG_ONLY and NOT_IN_PRODUCT macros. (Closed)

Created:
4 years, 10 months ago by Ivan Posva

Modified:
4 years, 10 months ago

Reviewers:
Florian Schneider, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Add DEBUG_ONLY and NOT_IN_PRODUCT macros. - Remove user_name_ field from RawClass using macros. - Consolidate "#ifndef PRODUCT" and "#ifdef DEBUG" code using macros. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c822c34af6e89193056c7bf552967770cdfecd94

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -159 lines)			Patch
M	runtime/platform/globals.h	View		3 chunks	+32 lines, -3 lines	0 comments	Download
M	runtime/tests/vm/vm.status	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/ast_printer.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1	24 chunks	+69 lines, -123 lines	0 comments	Download
M	runtime/vm/dart.cc	View		4 chunks	+14 lines, -22 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/globals.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/timeline.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Ivan Posva

4 years, 10 months ago (2016-02-20 01:48:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c822c34af6e89193056c7bf552967770cdfecd94 (presubmit successful).