Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6038)

Unified Diff: chrome/browser/ui/cocoa/applescript/window_applescript.mm

Issue 17151010: Move histograms and supporting code that don't belong in content out. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/applescript/window_applescript.mm
===================================================================
--- chrome/browser/ui/cocoa/applescript/window_applescript.mm (revision 206723)
+++ chrome/browser/ui/cocoa/applescript/window_applescript.mm (working copy)
@@ -21,6 +21,7 @@
#include "chrome/browser/ui/cocoa/applescript/error_applescript.h"
#import "chrome/browser/ui/cocoa/applescript/tab_applescript.h"
#include "chrome/browser/ui/host_desktop.h"
+#include "chrome/browser/ui/tab_contents/core_tab_helper.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/web_contents.h"
@@ -179,7 +180,8 @@
browser_,
GURL(chrome::kChromeUINewTabURL),
content::PAGE_TRANSITION_TYPED);
- contents->SetNewTabStartTime(newTabStartTime);
+ CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(contents);
+ core_tab_helper->set_new_tab_start_time(newTabStartTime);
Avi (use Gerrit) 2013/06/18 21:20:33 Kinda bummed that we have to paste this code every
jam 2013/06/18 21:28:43 well, this is translating calls that were to conte
Avi (use Gerrit) 2013/06/18 21:32:47 SG.
[aTab setWebContents:contents];
}
@@ -196,7 +198,9 @@
params.disposition = NEW_FOREGROUND_TAB;
params.tabstrip_index = index;
chrome::Navigate(&params);
- params.target_contents->SetNewTabStartTime(newTabStartTime);
+ CoreTabHelper* core_tab_helper =
+ CoreTabHelper::FromWebContents(params.target_contents);
+ core_tab_helper->set_new_tab_start_time(newTabStartTime);
[aTab setWebContents:params.target_contents];
}

Powered by Google App Engine
This is Rietveld 408576698