Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1715003002: Different approach to fixing file to URI mapping. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Different approach to fixing file to URI mapping. Relay on other order of library declarations in the SDK. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/576e6cbfc48a64bca15ad6a63046a6442667ae91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/sdk.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-19 19:43:02 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-19 19:44:34 UTC) #2
scheglov
4 years, 10 months ago (2016-02-19 20:12:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
576e6cbfc48a64bca15ad6a63046a6442667ae91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698