Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1714973003: Use --package-root when call build_sdk_summaries.dart script. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use --package-root when call build_sdk_summaries.dart script. TBR R=brianwilkerson@google.com,whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/850e8d7309e7f97463477e87e7163031784a6d9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M utils/dartanalyzer/dartanalyzer.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-20 03:46:12 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as 850e8d7309e7f97463477e87e7163031784a6d9f (presubmit successful).
4 years, 10 months ago (2016-02-20 03:51:28 UTC) #3
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-20 15:58:09 UTC) #4
Bill Hesse
4 years, 10 months ago (2016-02-22 10:25:14 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698