Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 1714913002: Reland: Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/... (Closed)

Created:
4 years, 10 months ago by mcasas
Modified:
4 years, 10 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, Peter Beverloo, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/... Reland: "Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/..." which was reverted due to Android bots failing. This reland adds a capture_jni_registrar file pair that basically intitializes the JNI VideoCapture*.java links, and adds the necessary dependency and call site for that. Original CL description ------------------------------------------------ ** No code changes (except git cl format kicked by presbumit). ** This CL refactors the VideoCapture*java classes from being under media/base/android/java/... into media/capture/video/android/java/... with the idea of bringing all such classes under a single roof as a preparation for http://crbug.com/584797 (CL http://crrev.com/1699553002) which creates an entity (very similar to media/cast/ and media/midi/) with its own .gn and .gyp. BUG=587693, 584797 Committed: https://crrev.com/e17550001f7960b3c21f2fb406d1c4fb0d8fa8ba Cr-Commit-Position: refs/heads/master@{#376562}

Patch Set 1 : Verbatim http://crrev.com/1705333003 #

Patch Set 2 : gyp-gn files and added a capture_jni_registrar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -1700 lines) Patch
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/app/DEPS View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/test/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 3 chunks +3 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/BUILD.gn View 1 5 chunks +11 lines, -5 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/BUILD.gn View 1 1 chunk +0 lines, -17 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/VideoCapture.java View 1 chunk +0 lines, -126 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 1 chunk +0 lines, -183 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 chunk +0 lines, -294 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 chunk +0 lines, -503 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 1 chunk +0 lines, -172 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/VideoCaptureFormat.java View 1 chunk +0 lines, -36 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/VideoCaptureTango.java View 1 chunk +0 lines, -197 lines 0 comments Download
M media/base/android/media_jni_registrar.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M media/base/run_all_unittests.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
A media/capture/video/android/BUILD.gn View 1 1 chunk +50 lines, -0 lines 0 comments Download
A media/capture/video/android/capture_jni_registrar.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A media/capture/video/android/capture_jni_registrar.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
A media/capture/video/android/java/src/org/chromium/media/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + media/capture/video/android/java/src/org/chromium/media/VideoCapture.java View 5 chunks +7 lines, -13 lines 0 comments Download
A + media/capture/video/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 5 chunks +15 lines, -24 lines 0 comments Download
A + media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java View 8 chunks +23 lines, -31 lines 0 comments Download
A + media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 13 chunks +21 lines, -33 lines 0 comments Download
A + media/capture/video/android/java/src/org/chromium/media/VideoCaptureFactory.java View 5 chunks +9 lines, -17 lines 0 comments Download
A + media/capture/video/android/java/src/org/chromium/media/VideoCaptureFormat.java View 1 chunk +1 line, -2 lines 0 comments Download
A + media/capture/video/android/java/src/org/chromium/media/VideoCaptureTango.java View 7 chunks +16 lines, -28 lines 0 comments Download
M media/media.gyp View 1 8 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
mcasas
qinmin@ PTAL media/*
4 years, 10 months ago (2016-02-19 21:28:38 UTC) #5
qinmin
lgtm
4 years, 10 months ago (2016-02-19 21:41:54 UTC) #6
mcasas
dalecurtis@ media/ Owners RS --> mecahnical conversions in gyps and gns _and_ reshuffled the jni ...
4 years, 10 months ago (2016-02-19 21:49:23 UTC) #8
Avi (use Gerrit)
lgtm stamp
4 years, 10 months ago (2016-02-19 21:59:24 UTC) #9
DaleCurtis
lgtm
4 years, 10 months ago (2016-02-19 21:59:54 UTC) #10
mcasas
dtrainor@: chrome/android/BUILD.gn RS please
4 years, 10 months ago (2016-02-19 22:07:32 UTC) #12
David Trainor- moved to gerrit
chrome/android/BUILD.gn lgtm
4 years, 10 months ago (2016-02-19 22:13:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714913002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714913002/60001
4 years, 10 months ago (2016-02-19 22:40:52 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 10 months ago (2016-02-19 22:55:02 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 22:56:57 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e17550001f7960b3c21f2fb406d1c4fb0d8fa8ba
Cr-Commit-Position: refs/heads/master@{#376562}

Powered by Google App Engine
This is Rietveld 408576698