mustash: Move gpu/ipc to gpu/ipc/common

mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ef5a0b65bc5d6b5e7b293db91d90ddfcdeed4995
Cr-Commit-Position: refs/heads/master@{#379416}

[Fady Samuel, 2016-02-19 19:51:41]

Description was changed from

==========
Move gpu/ipc to gpu/ipc/common

BUG=586389
==========

to

==========
Move gpu/ipc to gpu/ipc/common

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-02-19 19:52:01]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2016-02-19 20:06:24]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-02-19 20:06:40]

Description was changed from

==========
Move gpu/ipc to gpu/ipc/common

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move gpu/ipc to gpu/ipc/common

Move SurfaceTexture* to gpu/ipc/common/android too.

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-02-19 20:08:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/20001

[commit-bot: I haz the power, 2016-02-19 20:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 20:36:24]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Fady Samuel, 2016-02-19 20:52:43]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 20:54:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/40001

[commit-bot: I haz the power, 2016-02-19 21:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 21:06:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-02-19 21:26:43]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 21:28:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/60001

[commit-bot: I haz the power, 2016-02-19 21:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 21:48:25]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-02-19 21:58:14]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 22:03:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/80001

[commit-bot: I haz the power, 2016-02-19 22:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 22:27:20]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-02-22 17:15:59]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 17:17:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/100001

[commit-bot: I haz the power, 2016-02-22 17:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 17:39:12]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[piman, 2016-02-22 19:06:06]

lgtm

[Fady Samuel, 2016-02-22 19:56:26]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 19:58:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/120001

[Fady Samuel, 2016-02-22 19:59:36]

fsamuel@chromium.org changed reviewers:
+ jam@chromium.org, tsepez@chromium.org

[Fady Samuel, 2016-02-22 19:59:36]

+tsepez@ for:

  content/common/cc_messages.h
  content/common/gpu/gpu_messages.h
  gpu/ipc/BUILD.gn
  gpu/ipc/common/BUILD.gn
  gpu/ipc/common/android/surface_texture_manager.cc
  gpu/ipc/common/android/surface_texture_manager.h
  gpu/ipc/common/android/surface_texture_peer.cc
  gpu/ipc/common/android/surface_texture_peer.h
  gpu/ipc/common/gpu_command_buffer_traits.cc
  gpu/ipc/common/gpu_command_buffer_traits.h
  gpu/ipc/common/gpu_command_buffer_traits_multi.h
  gpu/ipc/common/id_type_traits.h
  gpu/ipc/gpu_command_buffer_traits.cc
  gpu/ipc/gpu_command_buffer_traits.h
  gpu/ipc/gpu_command_buffer_traits_multi.h
  gpu/ipc/id_type_traits.h
  ppapi/proxy/ppapi_messages.h

+jam@ for:

  components/mus/public/interfaces/BUILD.gn
  content/app/android/child_process_service.cc
  content/browser/android/browser_surface_texture_manager.h
  content/browser/android/in_process_surface_texture_manager.h
  content/browser/browser_main_loop.cc
  content/common/BUILD.gn
  content/common/android/surface_texture_manager.cc
  content/common/android/surface_texture_manager.h
  content/common/android/surface_texture_peer.cc
  content/common/android/surface_texture_peer.h
  content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc
  content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc
  content/common/gpu/stream_texture_android.cc
  content/renderer/gpu/stream_texture_host_android.h
  content/renderer/media/android/stream_texture_factory_synchronous_impl.cc
  content/test/content_test_suite.cc
  gpu/BUILD.gn
  gpu/command_buffer/common/BUILD.gn
  gpu/command_buffer/common/mojo.typemap
  gpu/gpu_ipc.gypi
  ppapi/BUILD.gn
  ppapi/native_client/BUILD.gn
  ppapi/proxy/BUILD.gn

[Tom Sepez, 2016-02-22 20:04:03]

RS LGTM on moving files.

[Tom Sepez, 2016-02-22 20:04:12]

RS LGTM on moving files.

[jam, 2016-02-22 20:36:30]

lgtm

it would be good if the cl description also explained the motivation for the
content->gpu file move (the linked bug doesn't)

[commit-bot: I haz the power, 2016-02-22 21:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 21:08:08]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Fady Samuel, 2016-02-22 21:08:40]

Description was changed from

==========
Move gpu/ipc to gpu/ipc/common

Move SurfaceTexture* to gpu/ipc/common/android too.

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu. In
an effort to decouple content/common/gpu from the rest of content/, this CL
moves SurfaceTexture* to gpu/ipc/common/android too.

BUG=586389, 586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-02-23 16:35:55]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 16:36:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/140001

[commit-bot: I haz the power, 2016-02-23 18:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 18:00:13]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Fady Samuel, 2016-02-24 00:43:16]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-02-24 00:43:17]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
tsepez@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1714903003/#ps160001
(title: "Rebased")

[commit-bot: I haz the power, 2016-02-24 00:45:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/160001

[Fady Samuel, 2016-02-24 01:25:52]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-02-24 01:25:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jam@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1714903003/#ps180001
(title: "Renderer Depends on GPU IPC")

[commit-bot: I haz the power, 2016-02-24 01:28:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/180001

[Fady Samuel, 2016-02-24 02:18:49]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-02-24 02:18:49]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jam@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1714903003/#ps200001
(title: "Fix gpu_ipc_common")

[commit-bot: I haz the power, 2016-02-24 02:22:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/200001

[commit-bot: I haz the power, 2016-02-24 02:54:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 02:54:19]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Fady Samuel, 2016-02-24 03:03:43]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 03:08:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/220001

[commit-bot: I haz the power, 2016-02-24 03:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 03:38:29]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-02-24 04:27:52]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-02-24 04:27:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jam@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1714903003/#ps240001
(title: "Remove gpu_ipc.gypi")

[commit-bot: I haz the power, 2016-02-24 04:28:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/240001

[commit-bot: I haz the power, 2016-02-24 05:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 05:44:19]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Fady Samuel, 2016-02-24 12:41:52]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 12:42:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/260001

[commit-bot: I haz the power, 2016-02-24 13:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 13:38:59]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Fady Samuel, 2016-02-24 16:51:46]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 16:53:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/280001

[Fady Samuel, 2016-02-24 17:26:43]

fsamuel@chromium.org changed reviewers:
+ thakis@chromium.org

[Fady Samuel, 2016-02-24 17:26:44]

thakis@: I can't get android_clang_dbg_recipe to behave. I don't really
understand gn/gyp very well. I was hoping to get your thoughts here since you
offered some thoughts on a related CL you recently reverted:
https://codereview.chromium.org/1708783002/


Thanks!

[Nico, 2016-02-24 17:28:59]

Can you describe how you think the component build works? Then I can check if
that's right or if there are problems in your mental model.

[Fady Samuel, 2016-02-24 17:37:52]

On 2016/02/24 17:28:59, Nico wrote:
> Can you describe how you think the component build works? Then I can check if
> that's right or if there are problems in your mental model.

I have a very rough mental model: Each component is a shared library/DLL. The
components are loaded on use. Symbols are resolved across components at runtime.
A class' symbols are not exported across component boundaries unless it's marked
as being so with the *_EXPORT macro. We can't have circular dependencies across
components. Is android_clang_dbg_recipe a component build?

[commit-bot: I haz the power, 2016-02-24 18:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 18:09:55]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Nico, 2016-02-24 20:22:24]

On 2016/02/24 17:37:52, Fady Samuel wrote:
> On 2016/02/24 17:28:59, Nico wrote:
> > Can you describe how you think the component build works? Then I can check
if
> > that's right or if there are problems in your mental model.
> 
> I have a very rough mental model: Each component is a shared library/DLL. The
> components are loaded on use. Symbols are resolved across components at
runtime.
> A class' symbols are not exported across component boundaries unless it's
marked
> as being so with the *_EXPORT macro. We can't have circular dependencies
across
> components. Is android_clang_dbg_recipe a component build?

That sounds all correct so far. Yes, all dbg bots do component builds (you can
check by going to the "ruhooks" step (gyp) or "generate build files" (gn) and
ctrl-f for 'component' to check any bot).

More guidelines:

* Every _EXPORT macro belongs to exactly one component
* If a static_library / source_set target uses an _EXPORT macro, the target
  must be linked _only_ into that one component
* If you want to link a static_library / source_set target into more than
  one component, that code must not use any _EXPORT macros -- but in that case,
  the code will end up in more than one component. Things will work, but it's
  wasteful. Consider making your code a new component with its own _EXPORT
  macro instead.

Does this patch invalidate any of these?

[Fady Samuel, 2016-02-24 20:53:32]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 20:58:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/300001

[commit-bot: I haz the power, 2016-02-24 21:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 21:35:57]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Fady Samuel, 2016-03-02 23:22:39]

Description was changed from

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu. In
an effort to decouple content/common/gpu from the rest of content/, this CL
moves SurfaceTexture* to gpu/ipc/common/android too.

BUG=586389, 586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu. In
an effort to decouple 
content/common/gpu from the rest of content/, this CL moves 
SurfaceTexture* to gpu/ipc/common/android too.

BUG=586389, 586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-03 20:33:32]

Description was changed from

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu. In
an effort to decouple 
content/common/gpu from the rest of content/, this CL moves 
SurfaceTexture* to gpu/ipc/common/android too.

BUG=586389, 586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389, 586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-03 20:33:33]

Description was changed from

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu. In
an effort to decouple 
content/common/gpu from the rest of content/, this CL moves 
SurfaceTexture* to gpu/ipc/common/android too.

BUG=586389, 586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389, 586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-03 20:38:04]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 20:39:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/320001

[commit-bot: I haz the power, 2016-03-03 20:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 20:45:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-03-04 18:50:58]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 18:51:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/340001

[commit-bot: I haz the power, 2016-03-04 18:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 18:57:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Fady Samuel, 2016-03-04 19:52:28]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 19:52:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/360001

[Fady Samuel, 2016-03-04 20:14:01]

Description was changed from

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389, 586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-04 20:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 20:30:48]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Fady Samuel, 2016-03-04 20:31:56]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 20:32:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/360001

[commit-bot: I haz the power, 2016-03-04 21:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 21:02:35]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Fady Samuel, 2016-03-04 21:50:09]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 21:50:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/380001

[commit-bot: I haz the power, 2016-03-04 23:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 23:47:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Fady Samuel, 2016-03-04 23:48:00]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-03-04 23:48:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jam@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1714903003/#ps380001
(title: "Fix Win64 build")

[commit-bot: I haz the power, 2016-03-04 23:48:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903003/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903003/380001

[commit-bot: I haz the power, 2016-03-05 00:35:57]

Description was changed from

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-05 00:36:00]

Committed patchset #20 (id:380001)

[commit-bot: I haz the power, 2016-03-05 00:38:07]

Description was changed from

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mustash: Move gpu/ipc to gpu/ipc/common

Mus will use the gpu service and client code currently in content/common/gpu.

BUG=586389
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ef5a0b65bc5d6b5e7b293db91d90ddfcdeed4995
Cr-Commit-Position: refs/heads/master@{#379416}
==========

[commit-bot: I haz the power, 2016-03-05 00:38:09]

Patchset 20 (id:??) landed as
https://crrev.com/ef5a0b65bc5d6b5e7b293db91d90ddfcdeed4995
Cr-Commit-Position: refs/heads/master@{#379416}