Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1714903002: Promote Notification action icons to stable. (Closed)

Created:
4 years, 10 months ago by Michael van Ouwerkerk
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promote Notification action icons to stable. Intent to implement and ship: https://goo.gl/GXb7lo BUG=581336 Committed: https://crrev.com/96390dca62e14a0faf254f226dc9b012e7a2e735 Cr-Commit-Position: refs/heads/master@{#376990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714903002/1
4 years, 10 months ago (2016-02-19 14:58:30 UTC) #2
Michael van Ouwerkerk
Peter, could you take a look as feature reviewer? Dimitri, could you take a look ...
4 years, 10 months ago (2016-02-19 14:59:43 UTC) #4
Peter Beverloo
lgtm! \o/ Two questions: (1) Why status=stable instead of removing the flag? Do you think ...
4 years, 10 months ago (2016-02-19 15:03:30 UTC) #5
Michael van Ouwerkerk
On 2016/02/19 15:03:30, Peter Beverloo wrote: > lgtm! \o/ > > Two questions: > (1) ...
4 years, 10 months ago (2016-02-19 15:07:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 16:23:42 UTC) #8
Michael van Ouwerkerk
Jochen, could you take a look please as owner? Dimitri is OOO.
4 years, 10 months ago (2016-02-23 10:51:57 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-23 14:33:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714903002/1
4 years, 10 months ago (2016-02-23 14:36:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 15:42:38 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 15:43:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96390dca62e14a0faf254f226dc9b012e7a2e735
Cr-Commit-Position: refs/heads/master@{#376990}

Powered by Google App Engine
This is Rietveld 408576698