gpu/gles2_conform_support/native/egl_native_windowless.cc - Issue 1714883002: command_buffer_gles2: Implement EGL default Display as a global object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/gles2_conform_support/native/egl_native_windowless.cc

Issue 1714883002: command_buffer_gles2: Implement EGL default Display as a global object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@command_buffer_gles2-multiple-contexts

Patch Set: workaround gtf Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/gles2_conform_support/native/egl_native_windowless.cc

diff --git a/gpu/gles2_conform_support/native/egl_native_windowless.cc b/gpu/gles2_conform_support/native/egl_native_windowless.cc

index 14172cfea1e2f13451fbb5fb9673a8c06f69188c..c54bd672f4f9102e132d7184d5b5df633105787b 100644

--- a/gpu/gles2_conform_support/native/egl_native_windowless.cc

+++ b/gpu/gles2_conform_support/native/egl_native_windowless.cc

@@ -24,9 +24,8 @@ GTFbool GTFNativeCreateWindow(EGLNativeDisplayType nativeDisplay,

EGLDisplay eglDisplay, EGLConfig eglConfig,

const char* title, int width, int height,

EGLNativeWindowType *pNativeWindow) {

- egl::Display* display = static_cast<egl::Display*>(eglDisplay);

- display->SetCreateOffscreen(width, height);

- return GTFtrue;

+ // GTF should use EGL pbuffer interface directly.

Kimmo Kinnunen 2016/02/24 12:32:43 Do you think you could fix GTF?

+ return GTFfalse;

Kimmo Kinnunen 2016/02/26 06:13:01 So there was this..

}

void GTFNativeDestroyWindow(EGLNativeDisplayType nativeDisplay,

« no previous file with comments | « gpu/gles2_conform_support/gles2_conform_support.gyp ('k') | gpu/gpu.gyp » ('j') | no next file with comments »