chrome/browser/resources/settings/search_page/search_page.html - Issue 1714843004: MD Settings: Search page, remove last usage of chrome.searchPrivate API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 1714843004: MD Settings: Search page, remove last usage of chrome.searchPrivate API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.css ('k') | chrome/browser/resources/settings/search_page/search_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_page/search_page.html

diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html

index 395f80ba756025e7bd71f70a5337f3a08b9e3cf8..3bb403507b5866688add6b4dbdbbab4af55948d3 100644

--- a/chrome/browser/resources/settings/search_page/search_page.html

+++ b/chrome/browser/resources/settings/search_page/search_page.html

@@ -1,8 +1,8 @@

-<link rel="import" href="chrome://md-settings/controls/settings_checkbox.html">

+<link rel="import" href="chrome://md-settings/search_engines_page/search_engines_browser_proxy.html">

@@ -16,16 +16,17 @@

<neon-animatable id="main">

- <select id="searchEnginesMenu"

- on-change="defaultEngineGuidChanged_">

- <template is="dom-repeat" items="[[searchEngines]]">

- <option value="[[item.guid]]">[[item.name]]</option>

+ <select id="searchEnginesMenu" on-change="onDefaultEngineChanged_">

+ <template is="dom-repeat" items="[[searchEngines_]]">

+ <option selected$="[[item.default]]" value="[[item.modelIndex]]">

+ [[item.name]]

+ </option>

</template>

</select>

</div>

- <paper-button class="link-button"

- i18n-content="searchEnginesManage" on-tap="onSearchEnginesTap_">

+ <paper-button class="link-button" i18n-content="searchEnginesManage"

+ on-tap="onManageSearchEnginesTap_">

</paper-button>

</div>

</neon-animatable>