Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1714803002: [turbofan] Reduce JSInliner dependencies on JSFunction. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reduce JSInliner dependencies on JSFunction. Ideally the JSInliner should not be concerned with JSFunction's at all, but only look at the SharedFunctionInfo. This reduces the uses of the concrete closure to two remaining cases, which we plan to fix soonish too. R=jarin@chromium.org Committed: https://crrev.com/c6433cb0589b6beea988b75dade85acc888d5310 Cr-Commit-Position: refs/heads/master@{#34135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M src/compiler/js-inlining.cc View 11 chunks +37 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-19 05:53:49 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a first step towards no JSFunction in JSInliner. Please take a look. ...
4 years, 10 months ago (2016-02-19 05:54:27 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-19 06:59:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714803002/1
4 years, 10 months ago (2016-02-19 07:00:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 07:01:59 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 07:02:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6433cb0589b6beea988b75dade85acc888d5310
Cr-Commit-Position: refs/heads/master@{#34135}

Powered by Google App Engine
This is Rietveld 408576698