Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1714763002: X87: More simplification and unification of frame handling. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: More simplification and unification of frame handling. port 55071954bcd65be6782388624b986e9751899377 (r34114) original commit message: Frame slots indexes numbers are used more consistently for computation in both TurboFan and Crankshaft. Specifically, Crankshaft now uses frame slot indexes in LChunk, removing the need for some special-case maths when building the deoptimization translation table. BUG= Committed: https://crrev.com/b5dc3dd2c10293cf616231638d0646f9d2289829 Cr-Commit-Position: refs/heads/master@{#34134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.h View 2 chunks +9 lines, -5 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 7 chunks +4 lines, -11 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-19 01:48:52 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-19 02:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714763002/1
4 years, 10 months ago (2016-02-19 05:29:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 05:54:58 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 05:55:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5dc3dd2c10293cf616231638d0646f9d2289829
Cr-Commit-Position: refs/heads/master@{#34134}

Powered by Google App Engine
This is Rietveld 408576698