Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 1714753004: [turbofan] Refactoring around the instruction scheduler. (Closed)

Created:
4 years, 10 months ago by baptiste.afsa1
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Refactoring around the instruction scheduler. Extract the logic to find out the best candidate out of the core of the scheduler. It allows more flexibility and make it easy to change the policy use to schedule the basic blocks. This patch also provide a new algorithm to randomly schedule the code in order to perform stress tests on the scheduler. R=jarin@chromium.org Committed: https://crrev.com/a2ceaa2390d489c07cfc4305d18cc39b7aecac35 Cr-Commit-Position: refs/heads/master@{#34156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -35 lines) Patch
M src/compiler/instruction-scheduler.h View 2 chunks +60 lines, -4 lines 0 comments Download
M src/compiler/instruction-scheduler.cc View 4 chunks +61 lines, -31 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
baptiste.afsa1
PTAL
4 years, 10 months ago (2016-02-19 11:27:29 UTC) #1
Jarin
lgtm
4 years, 10 months ago (2016-02-19 11:56:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714753004/1
4 years, 10 months ago (2016-02-19 14:32:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 14:53:22 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 14:53:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2ceaa2390d489c07cfc4305d18cc39b7aecac35
Cr-Commit-Position: refs/heads/master@{#34156}

Powered by Google App Engine
This is Rietveld 408576698