Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: src/factory.cc

Issue 1714753003: Don't internalize names that are array indexes since they aren't used for lookup (the index is) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/lookup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index 235faa3c3998dc1f9e22db7948927177d51abf92..22f6b0975498b975b53f0bc9a58cefd2cea1be1b 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -2229,9 +2229,6 @@ Handle<String> Factory::NumberToString(Handle<Object> number,
// We tenure the allocated string since it is referenced from the
// number-string cache which lives in the old space.
Handle<String> js_string = NewStringFromAsciiChecked(str, TENURED);
- // Make sure the string cached in the number cache is also the internalized
- // version of the same string.
- js_string = InternalizeString(js_string);
SetNumberStringCache(number, js_string);
return js_string;
}
« no previous file with comments | « no previous file | src/lookup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698