Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: mojo/shell/application_manager.h

Issue 1714753002: 7/ Eliminate on_application_end from ConnectParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@client_request
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/application_manager.h
diff --git a/mojo/shell/application_manager.h b/mojo/shell/application_manager.h
index 42c6446e321dc5e907b99923dae7213cd0230e4a..b244260a48beb6d91c51b1b3a09c1b10770fd939 100644
--- a/mojo/shell/application_manager.h
+++ b/mojo/shell/application_manager.h
@@ -71,6 +71,8 @@ class ApplicationManager : public ShellClient,
bool register_mojo_url_schemes);
~ApplicationManager() override;
+ void SetInstanceQuitCallback(base::Callback<void(const Identity&)> callback);
sky 2016/02/19 05:20:51 Document what this means.
+
// Completes a connection between a source and target application as defined
// by |params|, exchanging InterfaceProviders between them. If no existing
// instance of the target application is running, one will be loaded.
@@ -125,7 +127,6 @@ class ApplicationManager : public ShellClient,
ApplicationInstance* CreateInstance(
const Identity& target_id,
- const base::Closure& on_application_end,
const String& application_name,
mojom::ShellClientRequest* request);
@@ -155,10 +156,10 @@ class ApplicationManager : public ShellClient,
const String& application_name,
mojom::CapabilityFilterPtr base_filter);
- // Tries to load |target| with an ApplicationLoader. Returns true if one was
- // registered and it was loaded, in which case |request| is taken.
- bool LoadWithLoader(const Identity& target,
- mojom::ShellClientRequest* request);
+ // Tries to load |target| with an ApplicationLoader. Returns true if one was
+ // registered and it was loaded, in which case |request| is taken.
+ bool LoadWithLoader(const Identity& target,
+ mojom::ShellClientRequest* request);
// Returns the appropriate loader for |url|, or the default loader if there is
// no loader configured for the URL.
@@ -184,6 +185,7 @@ class ApplicationManager : public ShellClient,
WeakInterfacePtrSet<mojom::ApplicationManagerListener> listeners_;
+ base::Callback<void(const Identity&)> instance_quit_callback_;
base::TaskRunner* task_runner_;
scoped_ptr<NativeRunnerFactory> native_runner_factory_;
std::vector<scoped_ptr<NativeRunner>> native_runners_;

Powered by Google App Engine
This is Rietveld 408576698