Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: runtime/vm/class_finalizer.cc

Issue 1714743002: VM: Separate precompilation-specific code, make flags const. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/class_finalizer.h" 5 #include "vm/class_finalizer.h"
6 6
7 #include "vm/code_generator.h" 7 #include "vm/code_generator.h"
8 #include "vm/flags.h" 8 #include "vm/flags.h"
9 #include "vm/heap.h" 9 #include "vm/heap.h"
10 #include "vm/isolate.h" 10 #include "vm/isolate.h"
11 #include "vm/longjump.h" 11 #include "vm/longjump.h"
12 #include "vm/log.h" 12 #include "vm/log.h"
13 #include "vm/object_store.h" 13 #include "vm/object_store.h"
14 #include "vm/report.h" 14 #include "vm/report.h"
15 #include "vm/symbols.h" 15 #include "vm/symbols.h"
16 16
17 namespace dart { 17 namespace dart {
18 18
19 DEFINE_FLAG(bool, print_classes, false, "Prints details about loaded classes."); 19 DEFINE_FLAG(bool, print_classes, false, "Prints details about loaded classes.");
20 DEFINE_FLAG(bool, trace_class_finalization, false, "Trace class finalization."); 20 DEFINE_FLAG(bool, trace_class_finalization, false, "Trace class finalization.");
21 DEFINE_FLAG(bool, trace_type_finalization, false, "Trace type finalization."); 21 DEFINE_FLAG(bool, trace_type_finalization, false, "Trace type finalization.");
22 DECLARE_FLAG(bool, use_cha_deopt);
23 22
24 23
25 bool ClassFinalizer::AllClassesFinalized() { 24 bool ClassFinalizer::AllClassesFinalized() {
26 ObjectStore* object_store = Isolate::Current()->object_store(); 25 ObjectStore* object_store = Isolate::Current()->object_store();
27 const GrowableObjectArray& classes = 26 const GrowableObjectArray& classes =
28 GrowableObjectArray::Handle(object_store->pending_classes()); 27 GrowableObjectArray::Handle(object_store->pending_classes());
29 return classes.Length() == 0; 28 return classes.Length() == 0;
30 } 29 }
31 30
32 31
(...skipping 3286 matching lines...) Expand 10 before | Expand all | Expand 10 after
3319 ASSERT(fields_array.Length() == ByteBuffer::NumberOfFields()); 3318 ASSERT(fields_array.Length() == ByteBuffer::NumberOfFields());
3320 field ^= fields_array.At(0); 3319 field ^= fields_array.At(0);
3321 ASSERT(field.Offset() == ByteBuffer::data_offset()); 3320 ASSERT(field.Offset() == ByteBuffer::data_offset());
3322 name ^= field.name(); 3321 name ^= field.name();
3323 expected_name ^= String::New("_data"); 3322 expected_name ^= String::New("_data");
3324 ASSERT(String::EqualsIgnoringPrivateKey(name, expected_name)); 3323 ASSERT(String::EqualsIgnoringPrivateKey(name, expected_name));
3325 #endif 3324 #endif
3326 } 3325 }
3327 3326
3328 } // namespace dart 3327 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698