Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1714703002: Avoid redundant computation of enclosingElement in _getElementReferenceId (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid redundant computation of enclosingElement in _getElementReferenceId R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3896ab51e0b6472ffeac235a76400827c0cea54d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-18 23:35:30 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-19 00:31:07 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-19 16:39:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3896ab51e0b6472ffeac235a76400827c0cea54d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698