Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1714693002: Add more CHECKs to help investigate the Mojo bootstrap crash (Closed)

Created:
4 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more CHECKs to help investigate the Mojo bootstrap crash The only plausible explanation I have is that the EDK is being initialized with a null IO task runner. This should confirm/deny that suspicion. BUG=587807 TBR=jam@chromium.org Committed: https://crrev.com/8fa2980459d0a4e8c52429321e26bf19cfcfd907 Cr-Commit-Position: refs/heads/master@{#376323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ipc/mojo/scoped_ipc_support.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Ken Rockot(use gerrit already)
4 years, 10 months ago (2016-02-18 23:17:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714693002/1
4 years, 10 months ago (2016-02-18 23:19:55 UTC) #5
Anand Mistry (off Chromium)
lgtm
4 years, 10 months ago (2016-02-18 23:39:18 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 00:42:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714693002/1
4 years, 10 months ago (2016-02-19 00:47:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 00:58:05 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 00:59:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fa2980459d0a4e8c52429321e26bf19cfcfd907
Cr-Commit-Position: refs/heads/master@{#376323}

Powered by Google App Engine
This is Rietveld 408576698